You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/12/17 12:55:06 UTC
[GitHub] [incubator-doris] Youngwb commented on a change in pull request
#2485: Fix bug when spark on doris run long time
Youngwb commented on a change in pull request #2485: Fix bug when spark on doris run long time
URL: https://github.com/apache/incubator-doris/pull/2485#discussion_r358773212
##########
File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java
##########
@@ -40,9 +40,11 @@
String DORIS_REQUEST_RETRIES = "doris.request.retries";
String DORIS_REQUEST_CONNECT_TIMEOUT_MS = "doris.request.connect.timeout.ms";
String DORIS_REQUEST_READ_TIMEOUT_MS = "doris.request.read.timeout.ms";
+ String DORIS_REQUEST_QUERY_TIMEOUT_S = "doris.request.query.timeout.s";
int DORIS_REQUEST_RETRIES_DEFAULT = 3;
int DORIS_REQUEST_CONNECT_TIMEOUT_MS_DEFAULT = 30 * 1000;
int DORIS_REQUEST_READ_TIMEOUT_MS_DEFAULT = 30 * 1000;
+ int DORIS_REQUEST_QUERY_TIMEOUT_S_DEFAULT = -1;
Review comment:
Maybe we could set other default value, but spark on doris would get a wrong answer if query time exceeds default value without any error or warning. This wrong answer would mislead users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org