You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/24 09:21:52 UTC
[GitHub] [apisix] SylviaBABY opened a new pull request, #8393: docs: add GM plugin EN doc to make website display normally
SylviaBABY opened a new pull request, #8393:
URL: https://github.com/apache/apisix/pull/8393
### Description
In https://github.com/apache/apisix/pull/8389, APISIX adds `gm` plugin feature and use guide. Because of the Docusaurus, this content will not be displayed when there are only Chinese documents, and there must be corresponding documents.
However, considering that this function is only applicable to the Chinese scene, to make the document display normally, the content in the English file is still in Chinese.
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #8393: docs: add GM plugin EN doc to make website display normally
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #8393:
URL: https://github.com/apache/apisix/pull/8393#issuecomment-1326250750
Please make the CI pass, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY merged pull request #8393: docs: add GM plugin EN doc to make website display normally
Posted by GitBox <gi...@apache.org>.
SylviaBABY merged PR #8393:
URL: https://github.com/apache/apisix/pull/8393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on pull request #8393: docs: add GM plugin EN doc to make website display normally
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on PR #8393:
URL: https://github.com/apache/apisix/pull/8393#issuecomment-1326933056
> Please make the CI pass, thanks!
Done. Thanks for @spacewander and @SkyeYoung to approve^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org