You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/17 06:26:29 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #29749: [SPARK-32877][SQL] Fix Hive UDF not support decimal type in complex type

cloud-fan commented on a change in pull request #29749:
URL: https://github.com/apache/spark/pull/29749#discussion_r489999104



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
##########
@@ -47,7 +47,8 @@ private[hive] case class HiveSimpleUDF(
   with HiveInspectors
   with CodegenFallback
   with Logging
-  with UserDefinedExpression {
+  with UserDefinedExpression
+  with ImplicitCastInputTypes {

Review comment:
       `ScalaUDF` doesn't extend `ImplicitCastInputTypes` either. Does it have the same problem?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org