You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "tzulitai (via GitHub)" <gi...@apache.org> on 2023/06/17 18:26:34 UTC

[GitHub] [flink] tzulitai opened a new pull request, #22817: [FLINK-31731] Add backwards compatible constructor for DebeziumAvroSerializationSchema

tzulitai opened a new pull request, #22817:
URL: https://github.com/apache/flink/pull/22817

   ## What is the purpose of the change
   
   Adds a backwards compatible constructor for `DebeziumAvroSerializationSchema` that doesn't require passing an arg for the schema string. This allows the code in `apache/flink-connector-kafka` to build against Flink 1.18.x.
   
   The constructor args for `DebeziumAvroSerializationSchema` was modified in e818c11d to allow passing in a nullable schema string. There were test code in `apache/flink-connector-kafka` that used that constructor, and therefore broke with that change and could no longer simultaneously build against Flink 1.18.x and 1.17.x.
   
   There's a bigger question of _why_ the `flink-connector-kafka` tests are using the constructor which is meant to be `@Internal`, but for now this should have the nightly tests passing again and unblock Flink 1.18.x.
   
   ## Brief change log
   
   - Add back a constructor for `DebeziumAvroSerializationSchema` that doesn't require an arg for the schema string.
   
   ## Verifying this change
   
   The nightly tests in `flink-connector-kafka` should be passing again: https://github.com/apache/flink-connector-kafka/actions/workflows/weekly.yml
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? n/a
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tzulitai closed pull request #22817: [FLINK-31731] Add backwards compatible constructor for DebeziumAvroSerializationSchema

Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai closed pull request #22817: [FLINK-31731] Add backwards compatible constructor for DebeziumAvroSerializationSchema
URL: https://github.com/apache/flink/pull/22817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tzulitai commented on pull request #22817: [FLINK-31731] Add backwards compatible constructor for DebeziumAvroSerializationSchema

Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #22817:
URL: https://github.com/apache/flink/pull/22817#issuecomment-1602193998

   Merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22817: [FLINK-31731] Add backwards compatible constructor for DebeziumAvroSerializationSchema

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22817:
URL: https://github.com/apache/flink/pull/22817#issuecomment-1595826739

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cf332a0cfee80f2df17bbaec9227416e92380f2e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cf332a0cfee80f2df17bbaec9227416e92380f2e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cf332a0cfee80f2df17bbaec9227416e92380f2e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tzulitai commented on pull request #22817: [FLINK-31731] Add backwards compatible constructor for DebeziumAvroSerializationSchema

Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #22817:
URL: https://github.com/apache/flink/pull/22817#issuecomment-1595825739

   cc @MartijnVisser @PatrickRen @knaufk @mas-chen related to Flink 1.18.x  release blocker


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org