You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Funk (JIRA)" <ji...@apache.org> on 2007/04/18 13:50:15 UTC

[jira] Created: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

IHeaderResponse.renderOnUnLoadJavascript(String javascript);
------------------------------------------------------------

                 Key: WICKET-480
                 URL: https://issues.apache.org/jira/browse/WICKET-480
             Project: Wicket
          Issue Type: New Feature
          Components: wicket
    Affects Versions: 1.3
            Reporter: Martin Funk
            Priority: Minor


Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.

This is all just copy past, so it's a little smelly.
Beyond that I wouldn't mind to be able to specify which element an event should be added.

Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
===================================================================
--- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
+++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
@@ -197,4 +197,19 @@
                }
        }
 
+       /**
+        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
+        */
+       public void renderOnUnLoadJavascript(String javascript)
+       {
+               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
+               if (wasRendered(token) == false)
+               {
+                       renderJavascriptReference(WicketEventReference.INSTANCE);
+                       JavascriptUtils.writeJavascript(getResponse(),
+                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
+                       markRendered(token);
+               }
+       }
+
 }
Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
===================================================================
--- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
+++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
@@ -174,4 +174,11 @@
         * @param javascript
         */
        public void renderOnLoadJavascript(String javascript);
+
+       /**
+        * Renders javascript that is executed after the page is unloaded.
+        * 
+        * @param javascript
+        */
+       public void renderOnUnLoadJavascript(String javascript);
 }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Knopp resolved WICKET-480.
--------------------------------

       Resolution: Won't Fix
    Fix Version/s: 1.3

Sorry, I'm closing this as won't fix. OnUnload works as expected only in FF and IE. We need to support other browsers as well.

> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
> ------------------------------------------------------------
>
>                 Key: WICKET-480
>                 URL: https://issues.apache.org/jira/browse/WICKET-480
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Martin Funk
>            Priority: Minor
>             Fix For: 1.3
>
>
> Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event should be added.
> Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
> @@ -197,4 +197,19 @@
>                 }
>         }
>  
> +       /**
> +        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +        */
> +       public void renderOnUnLoadJavascript(String javascript)
> +       {
> +               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
> +               if (wasRendered(token) == false)
> +               {
> +                       renderJavascriptReference(WicketEventReference.INSTANCE);
> +                       JavascriptUtils.writeJavascript(getResponse(),
> +                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
> +                       markRendered(token);
> +               }
> +       }
> +
>  }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
> @@ -174,4 +174,11 @@
>          * @param javascript
>          */
>         public void renderOnLoadJavascript(String javascript);
> +
> +       /**
> +        * Renders javascript that is executed after the page is unloaded.
> +        * 
> +        * @param javascript
> +        */
> +       public void renderOnUnLoadJavascript(String javascript);
>  }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511050 ] 

Alastair Maw commented on WICKET-480:
-------------------------------------

I've now gone and read up a bit on this, and I'm not sure we want to provide onBeforeUnload after all, either. Safari prior to version 2 and Opera don't support it, I think. :-(

Needs some more testing.

> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
> ------------------------------------------------------------
>
>                 Key: WICKET-480
>                 URL: https://issues.apache.org/jira/browse/WICKET-480
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Martin Funk
>            Priority: Minor
>             Fix For: 1.3.0-beta1
>
>
> Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event should be added.
> Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
> @@ -197,4 +197,19 @@
>                 }
>         }
>  
> +       /**
> +        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +        */
> +       public void renderOnUnLoadJavascript(String javascript)
> +       {
> +               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
> +               if (wasRendered(token) == false)
> +               {
> +                       renderJavascriptReference(WicketEventReference.INSTANCE);
> +                       JavascriptUtils.writeJavascript(getResponse(),
> +                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
> +                       markRendered(token);
> +               }
> +       }
> +
>  }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
> @@ -174,4 +174,11 @@
>          * @param javascript
>          */
>         public void renderOnLoadJavascript(String javascript);
> +
> +       /**
> +        * Renders javascript that is executed after the page is unloaded.
> +        * 
> +        * @param javascript
> +        */
> +       public void renderOnUnLoadJavascript(String javascript);
>  }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Funk reopened WICKET-480:
--------------------------------


Now that a renderOnBeforeUnloadJavascript(String javascript) made it's way into the code, I'd like to see this issue reevaluated.

If Matejs argument still holdes true the renderOnBeforeUnloadJavascript(String javascript) has to go out, if not, I'd like to see the IHeaderResponse.renderOnUnLoadJavascript(String javascript); in.

> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
> ------------------------------------------------------------
>
>                 Key: WICKET-480
>                 URL: https://issues.apache.org/jira/browse/WICKET-480
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Martin Funk
>            Priority: Minor
>             Fix For: 1.3.0-beta1
>
>
> Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event should be added.
> Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
> @@ -197,4 +197,19 @@
>                 }
>         }
>  
> +       /**
> +        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +        */
> +       public void renderOnUnLoadJavascript(String javascript)
> +       {
> +               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
> +               if (wasRendered(token) == false)
> +               {
> +                       renderJavascriptReference(WicketEventReference.INSTANCE);
> +                       JavascriptUtils.writeJavascript(getResponse(),
> +                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
> +                       markRendered(token);
> +               }
> +       }
> +
>  }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
> @@ -174,4 +174,11 @@
>          * @param javascript
>          */
>         public void renderOnLoadJavascript(String javascript);
> +
> +       /**
> +        * Renders javascript that is executed after the page is unloaded.
> +        * 
> +        * @param javascript
> +        */
> +       public void renderOnUnLoadJavascript(String javascript);
>  }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511049 ] 

Alastair Maw commented on WICKET-480:
-------------------------------------

No. You should be using onBeforeUnload, which is the only thing that works consistently in all browsers. What does onUnload do for you in IE/FF that onBeforeUnload doesn't?

> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
> ------------------------------------------------------------
>
>                 Key: WICKET-480
>                 URL: https://issues.apache.org/jira/browse/WICKET-480
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Martin Funk
>            Priority: Minor
>             Fix For: 1.3.0-beta1
>
>
> Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event should be added.
> Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
> @@ -197,4 +197,19 @@
>                 }
>         }
>  
> +       /**
> +        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +        */
> +       public void renderOnUnLoadJavascript(String javascript)
> +       {
> +               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
> +               if (wasRendered(token) == false)
> +               {
> +                       renderJavascriptReference(WicketEventReference.INSTANCE);
> +                       JavascriptUtils.writeJavascript(getResponse(),
> +                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
> +                       markRendered(token);
> +               }
> +       }
> +
>  }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
> @@ -174,4 +174,11 @@
>          * @param javascript
>          */
>         public void renderOnLoadJavascript(String javascript);
> +
> +       /**
> +        * Renders javascript that is executed after the page is unloaded.
> +        * 
> +        * @param javascript
> +        */
> +       public void renderOnUnLoadJavascript(String javascript);
>  }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515051 ] 

Matej Knopp commented on WICKET-480:
------------------------------------

Well, onBeforeUnload doesn't work consistently across browsers so it will be probably removed. I'm not very happy with it, but IHeaderContributor is a core thing and we need to support browsers consistently. If you need to attach event to (before) unload you can still do it.

> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
> ------------------------------------------------------------
>
>                 Key: WICKET-480
>                 URL: https://issues.apache.org/jira/browse/WICKET-480
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Martin Funk
>            Priority: Minor
>             Fix For: 1.3.0-beta3
>
>
> Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event should be added.
> Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
> @@ -197,4 +197,19 @@
>                 }
>         }
>  
> +       /**
> +        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +        */
> +       public void renderOnUnLoadJavascript(String javascript)
> +       {
> +               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
> +               if (wasRendered(token) == false)
> +               {
> +                       renderJavascriptReference(WicketEventReference.INSTANCE);
> +                       JavascriptUtils.writeJavascript(getResponse(),
> +                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
> +                       markRendered(token);
> +               }
> +       }
> +
>  }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
> @@ -174,4 +174,11 @@
>          * @param javascript
>          */
>         public void renderOnLoadJavascript(String javascript);
> +
> +       /**
> +        * Renders javascript that is executed after the page is unloaded.
> +        * 
> +        * @param javascript
> +        */
> +       public void renderOnUnLoadJavascript(String javascript);
>  }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-480:
--------------------------------

    Fix Version/s:     (was: 1.3.0-beta1)
                   1.3.0-beta3

> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
> ------------------------------------------------------------
>
>                 Key: WICKET-480
>                 URL: https://issues.apache.org/jira/browse/WICKET-480
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Martin Funk
>            Priority: Minor
>             Fix For: 1.3.0-beta3
>
>
> Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event should be added.
> Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
> @@ -197,4 +197,19 @@
>                 }
>         }
>  
> +       /**
> +        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +        */
> +       public void renderOnUnLoadJavascript(String javascript)
> +       {
> +               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
> +               if (wasRendered(token) == false)
> +               {
> +                       renderJavascriptReference(WicketEventReference.INSTANCE);
> +                       JavascriptUtils.writeJavascript(getResponse(),
> +                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
> +                       markRendered(token);
> +               }
> +       }
> +
>  }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
> @@ -174,4 +174,11 @@
>          * @param javascript
>          */
>         public void renderOnLoadJavascript(String javascript);
> +
> +       /**
> +        * Renders javascript that is executed after the page is unloaded.
> +        * 
> +        * @param javascript
> +        */
> +       public void renderOnUnLoadJavascript(String javascript);
>  }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Funk updated WICKET-480:
-------------------------------

    Attachment: diff.txt

So how about something like this?
Support events that are compatible in all browsers and also allow developers to add javascript to events that they demand for explicitly.

Btw, what's a well recogniced resource on compatability issues between the different browsers? As you have seen I currntly can come up with quirksmode and wikipedia.

> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
> ------------------------------------------------------------
>
>                 Key: WICKET-480
>                 URL: https://issues.apache.org/jira/browse/WICKET-480
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Martin Funk
>            Priority: Minor
>             Fix For: 1.3.0-beta3
>
>         Attachments: diff.txt
>
>
> Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event should be added.
> Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
> @@ -197,4 +197,19 @@
>                 }
>         }
>  
> +       /**
> +        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +        */
> +       public void renderOnUnLoadJavascript(String javascript)
> +       {
> +               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
> +               if (wasRendered(token) == false)
> +               {
> +                       renderJavascriptReference(WicketEventReference.INSTANCE);
> +                       JavascriptUtils.writeJavascript(getResponse(),
> +                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
> +                       markRendered(token);
> +               }
> +       }
> +
>  }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
> @@ -174,4 +174,11 @@
>          * @param javascript
>          */
>         public void renderOnLoadJavascript(String javascript);
> +
> +       /**
> +        * Renders javascript that is executed after the page is unloaded.
> +        * 
> +        * @param javascript
> +        */
> +       public void renderOnUnLoadJavascript(String javascript);
>  }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);

Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511072 ] 

Martin Funk commented on WICKET-480:
------------------------------------

My reason to get into the subject, as you might have guessed, is:
http://www.google.com/apis/maps/documentation/#Memory_Leaks

If compatibility is an issue than onBeforeUnload definitely has to go out, as its a proprietary IE event with unclear support in other browsers.
http://en.wikipedia.org/wiki/DOM_Events#Microsoft-specific_events
http://www.quirksmode.org/js/events_events.html

Looking at
http://www.quirksmode.org/js/events_compinfo.html#t02
and
http://www.quirksmode.org/js/events_compinfo.html#t05
quirksmode claims that onUnload is at least as compatible as onLoad. So if compatibility is the reason not having onUnload in, than onLoad has to got, too.

> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
> ------------------------------------------------------------
>
>                 Key: WICKET-480
>                 URL: https://issues.apache.org/jira/browse/WICKET-480
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Martin Funk
>            Priority: Minor
>             Fix For: 1.3.0-beta1
>
>
> Where there is a renderOnLoadJavascript there ought to be a renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event should be added.
> Index: wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java     (Arbeitskopie)
> @@ -197,4 +197,19 @@
>                 }
>         }
>  
> +       /**
> +        * @see org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +        */
> +       public void renderOnUnLoadJavascript(String javascript)
> +       {
> +               List token = Arrays.asList(new Object[] { "javascript-event", "unload", javascript });
> +               if (wasRendered(token) == false)
> +               {
> +                       renderJavascriptReference(WicketEventReference.INSTANCE);
> +                       JavascriptUtils.writeJavascript(getResponse(),
> +                                       "Wicket.Event.add(window, \"unload\", function() { " + javascript + ";});");
> +                       markRendered(token);
> +               }
> +       }
> +
>  }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===================================================================
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java     (Arbeitskopie)
> @@ -174,4 +174,11 @@
>          * @param javascript
>          */
>         public void renderOnLoadJavascript(String javascript);
> +
> +       /**
> +        * Renders javascript that is executed after the page is unloaded.
> +        * 
> +        * @param javascript
> +        */
> +       public void renderOnUnLoadJavascript(String javascript);
>  }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.