You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by rj...@apache.org on 2011/07/29 19:31:27 UTC

svn commit: r1152314 - in /apr/apr/branches/1.2.x: CHANGES strings/apr_snprintf.c

Author: rjung
Date: Fri Jul 29 17:31:24 2011
New Revision: 1152314

URL: http://svn.apache.org/viewvc?rev=1152314&view=rev
Log:
Fix flag character '#' in combination with format
character 'x' in apr snprintf implementations.

Modified:
    apr/apr/branches/1.2.x/CHANGES
    apr/apr/branches/1.2.x/strings/apr_snprintf.c

Modified: apr/apr/branches/1.2.x/CHANGES
URL: http://svn.apache.org/viewvc/apr/apr/branches/1.2.x/CHANGES?rev=1152314&r1=1152313&r2=1152314&view=diff
==============================================================================
--- apr/apr/branches/1.2.x/CHANGES [utf-8] (original)
+++ apr/apr/branches/1.2.x/CHANGES [utf-8] Fri Jul 29 17:31:24 2011
@@ -1,6 +1,9 @@
                                                      -*- coding: utf-8 -*-
 Changes for APR 1.2.13
 
+  *) Fix flag character '#' in combination with format character 'x' in
+     apr snprintf implementations.  [Rainer Jung]
+
   *) Fix return value when apr_pollset_poll interrupted.
      PR 42580 [Basant Kumar Kukreja <basant.kukreja sun.com>]
 

Modified: apr/apr/branches/1.2.x/strings/apr_snprintf.c
URL: http://svn.apache.org/viewvc/apr/apr/branches/1.2.x/strings/apr_snprintf.c?rev=1152314&r1=1152313&r2=1152314&view=diff
==============================================================================
--- apr/apr/branches/1.2.x/strings/apr_snprintf.c (original)
+++ apr/apr/branches/1.2.x/strings/apr_snprintf.c Fri Jul 29 17:31:24 2011
@@ -708,7 +708,7 @@ APR_DECLARE(int) apr_vformatter(int (*fl
     apr_int64_t i_quad = 0;
     apr_uint64_t ui_quad;
     apr_int32_t i_num = 0;
-    apr_uint32_t ui_num;
+    apr_uint32_t ui_num = 0;
 
     char num_buf[NUM_BUF_SIZE];
     char char_buf[2];                /* for printing %% and %<unknown> */
@@ -946,7 +946,7 @@ APR_DECLARE(int) apr_vformatter(int (*fl
                             &num_buf[NUM_BUF_SIZE], &s_len);
                 }
                 FIX_PRECISION(adjust_precision, precision, s, s_len);
-                if (alternate_form && i_num != 0) {
+                if (alternate_form && ui_num != 0) {
                     *--s = *fmt;        /* 'x' or 'X' */
                     *--s = '0';
                     s_len += 2;



Re: svn commit: r1152314 - in /apr/apr/branches/1.2.x: CHANGES strings/apr_snprintf.c

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 7/29/2011 12:31 PM, rjung@apache.org wrote:
> Author: rjung
> Date: Fri Jul 29 17:31:24 2011
> New Revision: 1152314
> 
> URL: http://svn.apache.org/viewvc?rev=1152314&view=rev
> Log:
> Fix flag character '#' in combination with format
> character 'x' in apr snprintf implementations.

1.2?  Really ;-?