You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2017/08/03 09:19:56 UTC

[GitHub] brooklyn-server pull request #787: Don't validate an empty list of types.

GitHub user geomacy opened a pull request:

    https://github.com/apache/brooklyn-server/pull/787

    Don't validate an empty list of types.

    This is so as to avoid the side effect of the "getCatalog()" in the
    validate step, which does an unofficial catalog load that takes up
    unnecessary time on startup.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geomacy/brooklyn-server dont-validate-empty-list

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/787.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #787
    
----
commit 1fc2965c32be134f6a76163a65fb30cc5db24984
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date:   2017-08-03T09:15:43Z

    Don't validate an empty list of types.
    
    This is so as to avoid the side effect of the "getCatalog()" in the
    validate step, which does an unofficial catalog load that takes up
    unnecessary time on startup.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #787: Don't validate an empty list of types.

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/787


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #787: Don't validate an empty list of types.

Posted by geomacy <gi...@git.apache.org>.

Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/787
  
    I have run through startup and rebind, will merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #787: Don't validate an empty list of types.

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/787
  
    Code LGTM, but I've not tested it. Assuming you've run through the startup + rebind, then I'm happy for you to merge this @geomacy 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---