[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #18752: Fix linalg_potri and linalg_potrf operators for large tensor.

[GitBox <gi...@apache.org>]

access2rohit commented on a change in pull request #18752:
URL: https://github.com/apache/incubator-mxnet/pull/18752#discussion_r460149094



##########
File path: tests/nightly/test_large_array.py
##########
@@ -1167,6 +1168,32 @@ def check_correctness(mxnet_op, numpy_op, atol=1e-3):
     check_gather()
     check_binary_broadcast()
 
+def test_linalg():
+    def check_potrf():
+        # creating an identity matrix input
+        A = nd.zeros((LARGE_SQ_X, LARGE_SQ_X))
+        for i in range(LARGE_SQ_X):
+            A[i,i] = 1
+
+        out = nd.linalg.potrf(A)
+        # output should be an identity matrix
+        for i in range(LARGE_SQ_X):

Review comment:
       test for only 1 element. Its fine!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org