You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/21 17:47:25 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
tillrohrmann opened a new pull request #14722:
URL: https://github.com/apache/flink/pull/14722
## What is the purpose of the change
This commit allows to support different SlotPoolService implementations which can
accommodate different slot pool implementations (e.g. SlotPool, DeclarativeSlotPool, etc.).
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764831307
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345",
"triggerID" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"triggerType" : "PUSH"
}, {
"hash" : "4979927cd36c67a1a88f8f119a2dd9361b42d452",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12380",
"triggerID" : "4979927cd36c67a1a88f8f119a2dd9361b42d452",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4979927cd36c67a1a88f8f119a2dd9361b42d452 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12380)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764831307
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345",
"triggerID" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0df1e8780e5964c6fac844a6403d17b3ebab69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764831307
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345",
"triggerID" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0df1e8780e5964c6fac844a6403d17b3ebab69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764825583
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4979927cd36c67a1a88f8f119a2dd9361b42d452 (Fri May 28 08:07:03 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764831307
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345",
"triggerID" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"triggerType" : "PUSH"
}, {
"hash" : "4979927cd36c67a1a88f8f119a2dd9361b42d452",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12380",
"triggerID" : "4979927cd36c67a1a88f8f119a2dd9361b42d452",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0df1e8780e5964c6fac844a6403d17b3ebab69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345)
* 4979927cd36c67a1a88f8f119a2dd9361b42d452 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12380)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764825583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764831307
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0df1e8780e5964c6fac844a6403d17b3ebab69b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14722:
URL: https://github.com/apache/flink/pull/14722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764831307
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345",
"triggerID" : "d0df1e8780e5964c6fac844a6403d17b3ebab69b",
"triggerType" : "PUSH"
}, {
"hash" : "4979927cd36c67a1a88f8f119a2dd9361b42d452",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4979927cd36c67a1a88f8f119a2dd9361b42d452",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0df1e8780e5964c6fac844a6403d17b3ebab69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12345)
* 4979927cd36c67a1a88f8f119a2dd9361b42d452 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-767715314
Thanks for the review @rmetzger. Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14722: [FLINK-21077] Introduce SlotPoolService to abstract SlotPool from JobMaster
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14722:
URL: https://github.com/apache/flink/pull/14722#issuecomment-764825583
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d0df1e8780e5964c6fac844a6403d17b3ebab69b (Thu Jan 21 17:49:53 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org