You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org> on 2024/02/05 13:06:41 UTC
[PR] fix(plugins): Fix dashboard filter in Period Over Period KPI plugin [superset]
Antonio-RiveroMartnez opened a new pull request, #27013:
URL: https://github.com/apache/superset/pull/27013
### SUMMARY
When the PoP KPI chart is rendered in a dashboard and the dashboard has a time range filter, this filter is making the chart useless because it's overriding both queries thus no comparison is happening.
Also, previously if the bigNumber or the prev Number were zero, the % change would be zero when it should have been 100%.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Error:
https://github.com/apache/superset/assets/38889534/92ddc188-2aff-43b1-9f96-4af3ae4f06fa
Fix:
https://github.com/apache/superset/assets/38889534/4cf6162f-eba5-45f3-8d68-53834382f540
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugins): Fix dashboard filter in Period Over Period KPI plugin [superset]
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez merged PR #27013:
URL: https://github.com/apache/superset/pull/27013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugins): Fix dashboard filter in Period Over Period KPI plugin [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #27013:
URL: https://github.com/apache/superset/pull/27013#issuecomment-1927842401
🏷️ preset:2024.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org