[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #211: Fix flappy test - mng-6720-fail-fast

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #211:
URL: https://github.com/apache/maven-integration-testing/pull/211#discussion_r1021223185


##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6720FailFastTest.java:
##########
@@ -36,7 +34,7 @@
  * <a href="https://issues.apache.org/jira/browse/MNG-6720">MNG-6720</a>.
  *
  */
-public class MavenITmng6720FailFastTest
+class MavenITmng6720FailFastTest

Review Comment:
   Is the rest of our tests also package private?



##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6720FailFastTest.java:
##########
@@ -46,35 +44,34 @@ public MavenITmng6720FailFastTest()
     }
 
     @Test
-    public void testItShouldWaitForConcurrentModulesToFinish()
+    void testItShouldWaitForConcurrentModulesToFinish()
         throws Exception
     {
         File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-6720-fail-fast" );
 
         Verifier verifier = newVerifier( testDir.getAbsolutePath(), false );
-        verifier.setMavenDebug( false );
         verifier.setAutoclean( false );
-        verifier.addCliOption( "-T" );
-        verifier.addCliOption( "2" );
-        verifier.addCliOption( "-Dmaven.test.redirectTestOutputToFile=true" );
+        verifier.addCliArguments( "-T", "2" );
+        verifier.addCliArgument( "-Dmaven.test.redirectTestOutputToFile=true" );
+        verifier.addCliArguments( "clean", "test" );
 

Review Comment:
   Beautiful, this new API :-D



##########
core-it-suite/src/test/resources/mng-6720-fail-fast/pom.xml:
##########
@@ -35,15 +35,4 @@ under the License.
     <module>module-3</module>
   </modules>
 
-  <build>
-    <pluginManagement>
-      <plugins>
-        <plugin>
-          <groupId>org.apache.maven.plugins</groupId>
-          <artifactId>maven-resources-plugin</artifactId>
-          <version>3.2.0</version>
-        </plugin>
-      </plugins>
-    </pluginManagement>
-  </build>

Review Comment:
   Why not use plugin management in the part for those?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org