You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hemantk-12 (via GitHub)" <gi...@apache.org> on 2023/09/21 18:18:02 UTC
[GitHub] [ozone] hemantk-12 opened a new pull request, #5344: HDDS-9288. Intermittent failure in TestSnapshotDeletingService#testMultipleSnapshotKeyReclaim
hemantk-12 opened a new pull request, #5344:
URL: https://github.com/apache/ozone/pull/5344
## What changes were proposed in this pull request?
[TestSnapshotDeletingService#testMultipleSnapshotKeyReclaim](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java#L151) was updated as part of [HDDS-9173](https://issues.apache.org/jira/browse/HDDS-9173). [Cache assertion](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java#L196-L197) is flaky.
In this change, wait time is added to make sure that assertion passes.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9288
## How was this patch tested?
Ran the test on local repo 25 times: https://github.com/hemantk-12/ozone/actions/runs/6264936854/job/17012697424 and it passed all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9288. Intermittent failure in TestSnapshotDeletingService#testMultipleSnapshotKeyReclaim [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 merged PR #5344:
URL: https://github.com/apache/ozone/pull/5344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hemantk-12 commented on pull request #5344: HDDS-9288. Intermittent failure in TestSnapshotDeletingService#testMultipleSnapshotKeyReclaim
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #5344:
URL: https://github.com/apache/ozone/pull/5344#issuecomment-1730524827
@adoroszlai thanks for reviewing it.
> I'm not sure the patch fixes the problem. Tested in 10x10 runs (of `TestSnapshotDeletingService`, not only `testMultipleSnapshotKeyReclaim`) both without and with the patch:
You are right. It doesn't fix it. I need to do more deep dive here.
Seems like an issue with `Set#remove()` here: https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java#L108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9288. Intermittent failure in TestSnapshotDeletingService#testMultipleSnapshotKeyReclaim [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #5344:
URL: https://github.com/apache/ozone/pull/5344#issuecomment-1904547767
Thanks for the review @swamirishi and @adoroszlai.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #5344: HDDS-9288. Intermittent failure in TestSnapshotDeletingService#testMultipleSnapshotKeyReclaim
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5344:
URL: https://github.com/apache/ozone/pull/5344#issuecomment-1730244998
Thanks @hemantk-12 for working on this.
I'm not sure the patch fixes the problem. Tested in 10x10 runs (of `TestSnapshotDeletingService`, not only `testMultipleSnapshotKeyReclaim`) both without and with the patch:
* without: assertion failed in 1/100 cases ([1](https://github.com/adoroszlai/hadoop-ozone/actions/runs/6265759183/job/17015240378#step:5:4144))
* with: waitFor timed out in 2/100 cases ([1](https://github.com/adoroszlai/hadoop-ozone/actions/runs/6265778466/job/17015303232#step:5:8589), [2](https://github.com/adoroszlai/hadoop-ozone/actions/runs/6265778466/job/17015304090#step:5:8961))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org