[GitHub] [arrow] assignUser opened a new issue, #36076: [C++] deperacted gbenchmark cli flag causes error

["assignUser (via GitHub)" <gi...@apache.org>]

assignUser opened a new issue, #36076:
URL: https://github.com/apache/arrow/issues/36076

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   Google benchmark removed the long deprecated `color_print` cli flag in [1.6.1](https://github.com/google/benchmark/commit/ce92bbfb903308bf31530cfb69a36bb06e16d368). This will cause the benchmarks to error when run if benchmark version >=1.6.1 is used. We bundle 1.7.1 since 12.0.0.
   
   We set this flag unconditionally to false (for historic reasons I assume as this change is from 2017) [here](https://github.com/apache/arrow/blob/main/cpp/cmake_modules/BuildUtils.cmake#L570). I think we should not set the flag at all which will default to detecting if the env supports tty colors. If this causes cli issue we should set the correct flag and make it configurable.
   
   
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] assignUser closed issue #36076: [C++] deperacted gbenchmark cli flag causes error

["assignUser (via GitHub)" <gi...@apache.org>]

assignUser closed issue #36076: [C++] deperacted gbenchmark cli flag causes error
URL: https://github.com/apache/arrow/issues/36076


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org