You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by reductionista <gi...@git.apache.org> on 2018/08/31 22:54:42 UTC

[GitHub] madlib pull request #317: Fixed trailing whitespace in many sql_in files

GitHub user reductionista opened a pull request:

    https://github.com/apache/madlib/pull/317

    Fixed trailing whitespace in many sql_in files

    Fixed trailing whitespace in many sql_in files, which was causing extra line break to show up in html.
    
    Co-authored-by: Rahul Iyer <ri...@apache.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib whitespace

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #317
    
----
commit 90a29b1b768afdd2620d3655e267f7f32eb0b796
Author: Domino Valdano <dv...@...>
Date:   2018-08-31T22:43:31Z

    Fixed trailing whitespace in many sql_in files, which was causing extra line break to show up in html.
    
    Co-authored-by: Rahul Iyer <ri...@apache.org>

----


---

[GitHub] madlib issue #317: Fixed trailing whitespace in many sql_in files

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/317
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/667/



---

[GitHub] madlib issue #317: Fixed trailing whitespace in many sql_in files

Posted by fmcquillan99 <gi...@git.apache.org>.

Github user fmcquillan99 commented on the issue:

    https://github.com/apache/madlib/pull/317
  
    then let's merge it


---

[GitHub] madlib issue #317: Fixed trailing whitespace in many sql_in files

Posted by fmcquillan99 <gi...@git.apache.org>.

Github user fmcquillan99 commented on the issue:

    https://github.com/apache/madlib/pull/317
  
    Please add a hook to remove trailing white spaces in `*.sql_in` files automatically.
    
    I have changed my sublime settings to remove trailing white spaces, but other people may edit docs and not be doing this.


---

[GitHub] madlib issue #317: Fixed trailing whitespace in many sql_in files

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/317
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/669/



---

[GitHub] madlib pull request #317: Fixed trailing whitespace in many sql_in files

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/madlib/pull/317


---