You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by becketqin <gi...@git.apache.org> on 2016/11/05 00:23:58 UTC
[GitHub] kafka-site pull request #29: Update the website repo link in code.html to po...
GitHub user becketqin opened a pull request:
https://github.com/apache/kafka-site/pull/29
Update the website repo link in code.html to point to github.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/becketqin/kafka-site asf-site
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka-site/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #29: Update the website repo link in code.html to point to ...
Posted by becketqin <gi...@git.apache.org>.
Github user becketqin commented on the issue:
https://github.com/apache/kafka-site/pull/29
@ijuma Thanks for the review. Merged to the asf-site.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #29: Update the website repo link in code.html to point to ...
Posted by becketqin <gi...@git.apache.org>.
Github user becketqin commented on the issue:
https://github.com/apache/kafka-site/pull/29
@ijuma The github site has stated that it is mirrored from the Apache repo. I added the link anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #29: Update the website repo link in code.html to point to ...
Posted by ijuma <gi...@git.apache.org>.
Github user ijuma commented on the issue:
https://github.com/apache/kafka-site/pull/29
@becketqin, it's just that we point to the Apache git repo (which is the source repository) a few lines above for the code repo. We should probably be consistent and mention GitHub for both if we think that's useful. And we should probably point to the Apache one first (since it's the source repository) and mention the GitHub mirror second.
Finally, contributing documentation changes is a little different and there's a separate section for it in: http://kafka.apache.org/contributing.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #29: Update the website repo link in code.html to point to ...
Posted by ijuma <gi...@git.apache.org>.
Github user ijuma commented on the issue:
https://github.com/apache/kafka-site/pull/29
LGTM, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #29: Update the website repo link in code.html to point to ...
Posted by becketqin <gi...@git.apache.org>.
Github user becketqin commented on the issue:
https://github.com/apache/kafka-site/pull/29
@ijuma Does the updated page look good to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #29: Update the website repo link in code.html to point to ...
Posted by ijuma <gi...@git.apache.org>.
Github user ijuma commented on the issue:
https://github.com/apache/kafka-site/pull/29
Good catch, you probably want to include that link to that Apache Git repo as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site pull request #29: Update the website repo link in code.html to po...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka-site/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka-site issue #29: Update the website repo link in code.html to point to ...
Posted by becketqin <gi...@git.apache.org>.
Github user becketqin commented on the issue:
https://github.com/apache/kafka-site/pull/29
@ijuma That's fair. I updated the page. The thing I found confusing is that we have documentation in three places: 1) Kafka code repo 2) kafka-site repo 3) some documentation are just a wiki page. I'll update https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Website+Documentation+Changes to clarify this a little.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---