You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "coder999o (via GitHub)" <gi...@apache.org> on 2026/09/28 11:15:25 UTC
[PR] fix(alert): reject null delivery IDs before bulk retry [rocketmq-dashboard]
coder999o opened a new pull request, #5137:
URL: https://github.com/apache/rocketmq-dashboard/pull/5137
## What is the purpose of the change
A bulk retry request containing a null delivery ID could retry valid deliveries first, then fail while building the response. Reject the request before any delivery is changed.
## Brief changelog
- Validate all delivery IDs before starting a bulk retry and return HTTP 400 for null IDs.
- Add a regression test confirming that a mixed valid/null request does not access the delivery mapper.
## Verifying this change
- `cd server && mvn -q -Dtest=NotificationOutboxServiceTest,SystemAlertControllerTest test` (39 tests passed)
- `git diff --check` (passed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): reject null delivery IDs before bulk retry [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #5137:
URL: https://github.com/apache/rocketmq-dashboard/pull/5137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org