You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/09/17 00:31:19 UTC
[kudu-CR] test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16464
to review the following change.
Change subject: test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
......................................................................
test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
The test generates a large number (10 + 9 + ... + 1 = 55) of rowsets
with a schema containing 3 columns and a workload that has creates delta
files. On MacOS this is problematic, as 1) by using the file block
manager, we create a single file per CFile, and 2) the default file
limit is 256 (at least on macOS 10.15.4).
This patch alleviates this by adjusting the test to use fewer (5 + 4 +
... 1 = 15) rowsets. Despite the randomness in the workload, the test
passed on my machine 100/100 times.
Change-Id: Idf938f24b4a79537337f7a53d731f3162716145d
---
M src/kudu/tablet/compaction-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/16464/1
--
To view, visit http://gerrit.cloudera.org:8080/16464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf938f24b4a79537337f7a53d731f3162716145d
Gerrit-Change-Number: 16464
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16464 )
Change subject: test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
......................................................................
test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
The test generates a large number (10 + 9 + ... + 1 = 55) of rowsets
with a schema containing 3 columns and a workload that has creates delta
files. On MacOS this is problematic, as 1) by using the file block
manager, we create a single file per CFile, and 2) the default file
limit is 256 (at least on macOS 10.15.4).
This patch alleviates this by adjusting the test to use fewer (5 + 4 +
... 1 = 15) rowsets. Despite the randomness in the workload, the test
passed on my machine 100/100 times.
Change-Id: Idf938f24b4a79537337f7a53d731f3162716145d
Reviewed-on: http://gerrit.cloudera.org:8080/16464
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M src/kudu/tablet/compaction-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf938f24b4a79537337f7a53d731f3162716145d
Gerrit-Change-Number: 16464
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16464 )
Change subject: test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf938f24b4a79537337f7a53d731f3162716145d
Gerrit-Change-Number: 16464
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Sep 2020 01:29:41 +0000
Gerrit-HasComments: No
[kudu-CR] test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: test: reduce the number of files used by TestDuplicatedRowsRandomCompaction
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Idf938f24b4a79537337f7a53d731f3162716145d
Gerrit-Change-Number: 16464
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)