You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/16 00:44:32 UTC
[GitHub] [spark] ivoson opened a new pull request #35865: [SPARK-38106][SQL] Use error classes in the parsing errors of functions
ivoson opened a new pull request #35865:
URL: https://github.com/apache/spark/pull/35865
### What changes were proposed in this pull request?
Migrate the following errors in QueryExecutionErrors onto use error classes as INVALID_SQL_SYNTAX:
- functionNameUnsupportedError
- showFunctionsUnsupportedError
- showFunctionsInvalidPatternError
- createFuncWithBothIfNotExistsAndReplaceError
- defineTempFuncWithIfNotExistsError
- unsupportedFunctionNameError
- specifyingDBInCreateTempFuncError
- invalidNameForDropTempFunc
### Why are the changes needed?
Porting parsing errors of functions to new error framework.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35865: [SPARK-38106][SQL] Use error classes in the parsing errors of functions
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35865:
URL: https://github.com/apache/spark/pull/35865#issuecomment-1068978677
+1, LGTM. Merging to master.
Thank you, @ivoson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson commented on pull request #35865: [SPARK-38106][SQL] Use error classes in the parsing errors of functions
Posted by GitBox <gi...@apache.org>.
ivoson commented on pull request #35865:
URL: https://github.com/apache/spark/pull/35865#issuecomment-1068618031
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #35865: [SPARK-38106][SQL] Use error classes in the parsing errors of functions
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #35865:
URL: https://github.com/apache/spark/pull/35865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson commented on pull request #35865: [SPARK-38106][SQL] Use error classes in the parsing errors of functions
Posted by GitBox <gi...@apache.org>.
ivoson commented on pull request #35865:
URL: https://github.com/apache/spark/pull/35865#issuecomment-1069007295
@MaxGekk Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org