[GitHub] [arrow-datafusion] ShiKaiWi commented on a diff in pull request #6767: Support hex string literal

["ShiKaiWi (via GitHub)" <gi...@apache.org>]

ShiKaiWi commented on code in PR #6767:
URL: https://github.com/apache/arrow-datafusion/pull/6767#discussion_r1243079994


##########
datafusion/sql/src/expr/value.rs:
##########
@@ -357,3 +366,63 @@ fn has_units(val: &str) -> bool {
         || val.ends_with("nanosecond")
         || val.ends_with("nanoseconds")
 }
+
+/// Try to decode bytes from hex literal string.
+///
+/// None will be returned if the input literal is hex-invalid.
+fn try_decode_hex_literal(s: &str) -> Option<Vec<u8>> {

Review Comment:
   I guess the error detail of the decode failure is not necessary because the original invalid hex string literal is enough for troubleshooting if decode fails.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org