You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "charphi (via GitHub)" <gi...@apache.org> on 2024/02/12 12:35:44 UTC
[I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
charphi opened a new issue, #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133
I'm trying to make my [builds reproducible](https://maven.apache.org/guides/mini/guide-reproducible-builds.html) but it is not currently possible with `.nbm` files.
More specifically, the Maven property `project.build.outputTimestamp` is not used by the `nbm-maven-plugin` plugin.
I've tried to find a way in the plugin code but that didn't work.
Any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
Posted by "charphi (via GitHub)" <gi...@apache.org>.
charphi commented on issue #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133#issuecomment-1952123957
Most if not all of the problems come from the timestamps. `MakeNBM.java` seems to be the file to fix, but digging into the NetBeans source code is a bit overwhelming for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
Posted by "charphi (via GitHub)" <gi...@apache.org>.
charphi commented on issue #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133#issuecomment-1952138194
I'm using the https://diffoscope.org/ tool to see the difference between to builds and I've found the following problems:
- the manifest entry `OpenIDE-Module-Build-Version` is set to creation time both in `.jar` and `.nbm`
- the files in `.nbm` have the modification time set to the `.nbm` archive creation time
All these timestamps should use the value defined in the Maven property `project.build.outputTimestamp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on issue #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133#issuecomment-1941952670
Hi, the plugin use some Apache NetBeans harness make the nbm. So maybe the issue is in this file (ant task).
I'm not very aware of reproducible build technical parts so I may be wrong
Here is the file
https://github.com/apache/netbeans/blob/d30134f8f7d34f29a0c418f49015cbd1f9f7e71a/nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on issue #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133#issuecomment-1956846321
for problem 2, could be nice to talk into the dev mailing list. Because you will have more feedback than on this "side project"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on issue #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133#issuecomment-3536258835
FYI https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/netbeans/utilities/README.md
does not solve anything on the output of the plugin, but the plugin itself is reproducible :)
I'll have a look at helping on making output of the plugin reproducible: any pointer to existing discussion welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
Posted by "charphi (via GitHub)" <gi...@apache.org>.
charphi commented on issue #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133#issuecomment-1952159934
Problem 1 is simplier since it is located in the nbm plugin at https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/blob/aa1033839265ed33ea33c55eed5706c422caeb95/nbm-maven-plugin/src/main/java/org/apache/netbeans/nbm/NetBeansManifestUpdateMojo.java#L617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on issue #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133#issuecomment-1953802650
@charphi feel free to propose a PR. maybe setting up the timestamp via outputTimestamp or the current date for backward compatibility if the outputTimestamp is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [I] Reproducible builds [netbeans-mavenutils-nbm-maven-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on issue #133:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/133#issuecomment-3536501266
after first research, it seems the nbm jar creation is done in https://github.com/apache/netbeans/blob/master/nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java using a jar Ant task
jar Ant task can force entries modification time since Ant 1.10.2 https://ant.apache.org/manual/Tasks/jar.html
based on this first analysis, can Netbeans experts take next steps, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists