You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/01/10 12:06:00 UTC
[jira] [Work logged] (AVRO-3048) Using builders leads to performance degradation
[ https://issues.apache.org/jira/browse/AVRO-3048?focusedWorklogId=706040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706040 ]
ASF GitHub Bot logged work on AVRO-3048:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/22 12:05
Start Date: 10/Jan/22 12:05
Worklog Time Spent: 10m
Work Description: martin-g commented on pull request #1333:
URL: https://github.com/apache/avro/pull/1333#issuecomment-1008810079
@xkrogen Have you tried 1.11.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 706040)
Time Spent: 2h (was: 1h 50m)
> Using builders leads to performance degradation
> -----------------------------------------------
>
> Key: AVRO-3048
> URL: https://issues.apache.org/jira/browse/AVRO-3048
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.9.2, 1.10.1
> Reporter: Peter
> Assignee: Martin Jubelgas
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> When you do a .newBuilder() for avro generated classes, this will call
> org.apache.avro.specific.SpecificData.getForSchema:
>
> public static SpecificData getForSchema(Schema reader) {
> if (reader.getType() == Type.RECORD) {
> final String className = getClassName(reader);
> if (className != null) {
> final Class<?> clazz;
> try
> {
> clazz = Class.forName(className);
> return getForClass(clazz); }
> catch (ClassNotFoundException e)
> { return SpecificData.get();
> }
> }
> }
>
> which seems then to seldom find the value inside the try and a lot of ClassNotFoundException is thrown.
> Throwing internal exceptions has great performance penalties and in practice users of avro 1.9.x. and 1.10.x in high performance applications are forced not to use builders.
>
> Information about same problem is also found on:
> [https://forums.databricks.com/questions/50803/orgapacheavrospecificspecificdatagetforschema-sear.html]
> Problem exists on at least 1.9.2 and 1.10.1 (but not on 1.7.x) in OSGI environment
--
This message was sent by Atlassian Jira
(v8.20.1#820001)