[GitHub] [commons-csv] mykolapolonskyi commented on issue #47: CSV-247: CSVParser to check an empty header before checking duplicates.

[GitBox <gi...@apache.org>]

mykolapolonskyi commented on issue #47: CSV-247: CSVParser to check an empty header before checking duplicates.
URL: https://github.com/apache/commons-csv/pull/47#issuecomment-514291345
 
 
   hi there 
   I've found you PR related to the thing that I've catched - when csv file doesn't contain the header line I parsing should throw IllegalArgument Exception 
   
   Maybe this test can be added as part of your PR because seems that fix should be in place that you`ve edited? what do you think?
   
   ```
   private enum CSVHeaders {
           Name;
   }
   @Test(expected = IllegalArgumentException.class)
   public void testMissingHeaderWithEnumConfiguration() throws Exception {
   final Reader in = new StringReader("not name");
   CSVFormat.DEFAULT.withHeader(CSVHeaders.class).withIgnoreHeaderCase().parse(in).iterator();
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services