You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/04/20 06:26:01 UTC
[GitHub] [spark] itholic opened a new pull request, #40868: [SPARK-43210][CONNECT][PYTHON] Introduce `PySparkAssertionError`
itholic opened a new pull request, #40868:
URL: https://github.com/apache/spark/pull/40868
### What changes were proposed in this pull request?
This PR proposes to introduce new error for PySpark, and also applied it to existing AssertionError from `python/pyspark/sql/connect/types.py`.
### Why are the changes needed?
To cover the built-in AssertionError by PySpark error framework.
### Does this PR introduce _any_ user-facing change?
No, it's internal error framework improvement.
### How was this patch tested?
The existing CI should pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #40868: [SPARK-43210][CONNECT][PYTHON] Introduce `PySparkAssertionError`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40868: [SPARK-43210][CONNECT][PYTHON] Introduce `PySparkAssertionError`
URL: https://github.com/apache/spark/pull/40868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40868: [SPARK-43210][CONNECT][PYTHON] Introduce `PySparkAssertionError`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40868:
URL: https://github.com/apache/spark/pull/40868#issuecomment-1517268667
the failed test should be unrelated, but would you mind re-runing it for double check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40868: [SPARK-43210][CONNECT][PYTHON] Introduce `PySparkAssertionError`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40868:
URL: https://github.com/apache/spark/pull/40868#issuecomment-1519237747
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org