You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Nakomis <gi...@git.apache.org> on 2014/07/07 14:15:58 UTC
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
GitHub user Nakomis opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/49
Brooklyn 20 apache rat
This resolved BROOKLYN-20
Note, this is dependent upon https://github.com/apache/incubator-brooklyn/pull/43
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Nakomis/incubator-brooklyn BROOKLYN-20-apache-rat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 53cfcf21459ca527df50e96cc575f94177b8e511
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-02T15:49:42Z
Removed java copyright headers that contain 'Cloudsoft Corp'
commit 136b6580aa704425dc0bbce573ea23d8cf4c5c12
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-02T16:11:57Z
Added apache copyright header to all java files
commit b9e4bca952ee71291aeb66716f032e8258d3a982
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-02T16:17:29Z
Added apache copyright header to all groovy files
commit c5452940903d59e36fe2cb3c8e20321838cb274d
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-02T16:19:57Z
Added apache copyright header to all yaml files
commit eb0f1b3a59a330bd524a4357bbdbd94f095816b4
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-03T10:52:10Z
Added apache copyright header to (non 3rd-party) js files
commit cb0e35fc41abc519f131bde5d32865fba52e1f2f
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-03T11:04:43Z
Added apache copyright header to html files
commit 6b14fc20a28f7ebf7d88f6a5fc56cb4740dbf0c9
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-03T12:10:18Z
Added apache copyright header to properties and sh files
commit 8c74a6f663849c4f56b3284d3516d7263833d4e4
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-03T12:29:55Z
Added apache copyright header to a few misc script files
commit fe22afa455c1f0afb6c61e1b38d0ad7ed97468e3
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-03T12:30:46Z
Added apache copyright header to css files
commit aae30d3fde399b8d4cbc5d5828f9c3ad5bfc2931
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-03T12:34:04Z
Added apache copyright header to README.txt files
commit 724615a8d3b9f8cada2fcf4c57e2ad4f4d082c60
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-03T13:22:46Z
Manually added apache copyright header to several misc files
commit ccc647cb3373d53416a050fc382e2c6236ff1889
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-03T15:38:49Z
Removed apache licence from 3-rd party maxmind source
commit ebc427cea197efe7a5c5c87c519bd68cbcd46d17
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-04T11:03:22Z
Added apache copyright header (inc. 4 spaces) to all xml files
commit 89d552faa27556a6eab56cdac3d5f70e717ee836
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-04T11:04:45Z
Added updated apache copyright header to all sql files
commit 6fab1a496868f468d99bf60b54b6f22ae772bfe7
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-04T11:15:06Z
Moved #!/bin/bash to the start of bash scripts (added where missing
commit c3fb3310cad5a325e6e1d8602a3a6efd057001ef
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-04T11:57:44Z
Added apache copyright header to jsp files (under <html>)
commit e6c3e6b21e920656e32d5f50a6db54b8dd926b81
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-04T12:17:45Z
Updated various files following PR comments
commit 18aef92451406656082ae36e9f756ec2eb8c0d10
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-04T12:25:43Z
Updated following PR review
commit 25b7698b7fcd465e8229286a6c72a3abb1b412ac
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-04T12:50:25Z
Added Apache header to new (camp) java files
commit e48b1e7bae7afa695b344e67c790653627993e97
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-07T11:06:21Z
Added apache-rat to main build (verify phase)
commit 9c991179f70262e1f28ff2dc968fd00ac28e8c41
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-07T11:07:01Z
Added apache headers, where missing
commit e1b055fcfa81962825e5381f58c1306609f95be8
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-07T12:05:45Z
Moved rat exclusions into subproject poms
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14706961
--- Diff: software/nosql/pom.xml ---
@@ -159,5 +159,23 @@
<scope>test</scope>
</dependency>
</dependencies>
-
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <version>0.10</version>
+ <configuration>
+ <excludes combine.children="append">
+ <exclude>**/couchdb/couch.uri</exclude>
+ <exclude>**/riak/vm.args</exclude>
--- End diff --
@aledsage agreed. However that should not stop us merging this PR, which is designed to stop any future infractions before they even become PRs. There are known cases in the current code where we have license compliance issues so we should deal with `couch.uri` and other suspicious exclusions at that time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14705875
--- Diff: pom.xml ---
@@ -678,6 +662,64 @@
</execution>
</executions>
</plugin>
+ <!-- Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <version>0.10</version>
+ <executions>
+ <execution>
+ <phase>verify</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <!--
+ If you wish to override this list in the component (child) pom, ensure you use
+ <excludes combine.children="merge">
+ so that the child pom entries replace the parent entries
+ -->
+ <excludes combine.children="append">
+ <!-- git and IDE project files -->
+ <!-- see https://issues.apache.org/jira/browse/RAT-107 -->
+ <exclude>**/.git/**</exclude>
+ <exclude>**/.gitignore</exclude>
+ <exclude>**/.idea/**</exclude>
+ <exclude>**/*.iml</exclude>
+ <exclude>**/.classpath/**</exclude>
+ <exclude>**/.project</exclude>
+ <exclude>**/.settings/**</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/brooklyn*.log.*</exclude>
+ <!-- files not requiring licence -->
+ <exclude>ignored/**</exclude>
+ <exclude>LICENSE.md</exclude>
+ <exclude>**/MANIFEST.MF</exclude>
+ <exclude>**/test-output/**</exclude>
+ <exclude>**/*.pem.pub</exclude>
+ <exclude>**/*.svg</exclude>
+ <exclude>**/*.crt</exclude>
+ <exclude>**/*.csr</exclude>
+ <exclude>**/*.key</exclude>
+ <exclude>**/*.key.org</exclude>
+ <exclude>**/*.psd</exclude>
+ <exclude>**/*.json</exclude>
+ <exclude>**/*.plxarc</exclude>
+ <exclude>**/services/brooklyn.location.LocationResolver</exclude>
--- End diff --
Presumably these services files could have the comment at the top as well? Not sure if required. @richardcloudsoft what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48922619
Thanks @Nakomis. Can you rebase so it's mergeable, and then I'll merge it.
@ahgittin @grkvlt @richardcloudsoft @sjcorbett @andreaturli all take note. Any subsequent build will fail if a PR is merged that is missing the official apache header from a non-binary file, unless an exception is added to the pom.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48611717
Should now work with both `mvn apache-rat:check -Dfile.encoding=ISO8859_1` and `mvn apache-rat:check -Dfile.encoding=UTF8`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48469404
@Nakomis build fails for me - can you take a look at usage/launcher/target/rat.txt:
Unapproved licenses:
/Users/aled/repos/apache/incubator-brooklyn/usage/launcher/src/test/resources/client_cert
/Users/aled/repos/apache/incubator-brooklyn/usage/launcher/src/test/resources/server_cert
*******************************
Archives:
+ /Users/aled/repos/apache/incubator-brooklyn/usage/launcher/src/test/resources/hello-world.war
I don't want to merge yet if it will cause all builds to fail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48611611
Rebased, and fixed remaining issue (including additional files that had been merged to master)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14706576
--- Diff: pom.xml ---
@@ -678,6 +662,64 @@
</execution>
</executions>
</plugin>
+ <!-- Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <version>0.10</version>
+ <executions>
+ <execution>
+ <phase>verify</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <!--
+ If you wish to override this list in the component (child) pom, ensure you use
+ <excludes combine.children="merge">
+ so that the child pom entries replace the parent entries
+ -->
+ <excludes combine.children="append">
+ <!-- git and IDE project files -->
+ <!-- see https://issues.apache.org/jira/browse/RAT-107 -->
+ <exclude>**/.git/**</exclude>
+ <exclude>**/.gitignore</exclude>
+ <exclude>**/.idea/**</exclude>
+ <exclude>**/*.iml</exclude>
+ <exclude>**/.classpath/**</exclude>
+ <exclude>**/.project</exclude>
+ <exclude>**/.settings/**</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/brooklyn*.log.*</exclude>
+ <!-- files not requiring licence -->
+ <exclude>ignored/**</exclude>
+ <exclude>LICENSE.md</exclude>
+ <exclude>**/MANIFEST.MF</exclude>
+ <exclude>**/test-output/**</exclude>
+ <exclude>**/*.pem.pub</exclude>
+ <exclude>**/*.svg</exclude>
+ <exclude>**/*.crt</exclude>
+ <exclude>**/*.csr</exclude>
+ <exclude>**/*.key</exclude>
+ <exclude>**/*.key.org</exclude>
+ <exclude>**/*.psd</exclude>
+ <exclude>**/*.json</exclude>
--- End diff --
I excluded json as it doesn't support comments, I had a quick look at json files in jClouds (just as an example of an Apache TLP) and their json files don't include the apache header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14706993
--- Diff: pom.xml ---
@@ -678,6 +662,64 @@
</execution>
</executions>
</plugin>
+ <!-- Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <version>0.10</version>
+ <executions>
+ <execution>
+ <phase>verify</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <!--
+ If you wish to override this list in the component (child) pom, ensure you use
+ <excludes combine.children="merge">
+ so that the child pom entries replace the parent entries
+ -->
+ <excludes combine.children="append">
+ <!-- git and IDE project files -->
+ <!-- see https://issues.apache.org/jira/browse/RAT-107 -->
+ <exclude>**/.git/**</exclude>
+ <exclude>**/.gitignore</exclude>
+ <exclude>**/.idea/**</exclude>
+ <exclude>**/*.iml</exclude>
+ <exclude>**/.classpath/**</exclude>
+ <exclude>**/.project</exclude>
+ <exclude>**/.settings/**</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/brooklyn*.log.*</exclude>
+ <!-- files not requiring licence -->
+ <exclude>ignored/**</exclude>
+ <exclude>LICENSE.md</exclude>
+ <exclude>**/MANIFEST.MF</exclude>
+ <exclude>**/test-output/**</exclude>
+ <exclude>**/*.pem.pub</exclude>
+ <exclude>**/*.svg</exclude>
+ <exclude>**/*.crt</exclude>
+ <exclude>**/*.csr</exclude>
+ <exclude>**/*.key</exclude>
+ <exclude>**/*.key.org</exclude>
+ <exclude>**/*.psd</exclude>
+ <exclude>**/*.json</exclude>
--- End diff --
s/jClouds/jclouds/ `</pedantic>`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14705854
--- Diff: pom.xml ---
@@ -678,6 +662,64 @@
</execution>
</executions>
</plugin>
+ <!-- Needed for command-line access, e.g mvn apache-rat:rat and mvn apache-rat:check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <version>0.10</version>
+ <executions>
+ <execution>
+ <phase>verify</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <!--
+ If you wish to override this list in the component (child) pom, ensure you use
+ <excludes combine.children="merge">
+ so that the child pom entries replace the parent entries
+ -->
+ <excludes combine.children="append">
+ <!-- git and IDE project files -->
+ <!-- see https://issues.apache.org/jira/browse/RAT-107 -->
+ <exclude>**/.git/**</exclude>
+ <exclude>**/.gitignore</exclude>
+ <exclude>**/.idea/**</exclude>
+ <exclude>**/*.iml</exclude>
+ <exclude>**/.classpath/**</exclude>
+ <exclude>**/.project</exclude>
+ <exclude>**/.settings/**</exclude>
+ <exclude>**/*.log</exclude>
+ <exclude>**/brooklyn*.log.*</exclude>
+ <!-- files not requiring licence -->
+ <exclude>ignored/**</exclude>
+ <exclude>LICENSE.md</exclude>
+ <exclude>**/MANIFEST.MF</exclude>
+ <exclude>**/test-output/**</exclude>
+ <exclude>**/*.pem.pub</exclude>
+ <exclude>**/*.svg</exclude>
+ <exclude>**/*.crt</exclude>
+ <exclude>**/*.csr</exclude>
+ <exclude>**/*.key</exclude>
+ <exclude>**/*.key.org</exclude>
+ <exclude>**/*.psd</exclude>
+ <exclude>**/*.json</exclude>
--- End diff --
Is this ok to exclude?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14705793
--- Diff: examples/pom.xml ---
@@ -57,5 +57,20 @@
<module>simple-messaging-pubsub</module>
<module>simple-nosql-cluster</module>
</modules>
-
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <version>0.10</version>
--- End diff --
Can you include this version number as a property in the root pom.xml (similar to @richardcloudsoft 's changes in https://github.com/apache/incubator-brooklyn/pull/50)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48453237
Rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48461157
Will rat succeed or fail in our current master? (I'm running it now on your branch to find out).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48475389
@aledsage this appears to be due to Rat's behaviour changing depending on the value of `System.getProperty("file.encoding")`. See the `isBinary(InputStream in)` method in [1]. @richardcloudsoft and I debugged this during review and Richard has added these files as exclusions.
To ensure that it is this, can you try `mvn apache-rat:check -Dfile.encoding=UTF8`, which should work and `mvn apache-rat:check -Dfile.encoding=ISO8859_1` which should fail
Also, as #43 is being reverted, we'll need to wait until #56 is merged
[1]: http://svn.apache.org/repos/asf/creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/BinaryGuesser.java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48453372
Once merged, the rat check will run as part of the main build, rat.txt reports are written to the target folder of all subprojects. The check can also be run (much faster) using `mvn apache-rat:check`. In a pinch if you need to build and rat is failing you can use `mvn clean install -Drat.numUnapprovedLicenses=99999'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-49012813
Rebased as requested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48461296
It should pass, but @Nakomis and I have discovered an issue which we are working through - RAT's results change depending on the character set that Java is using... so not ready to merge yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#discussion_r14705970
--- Diff: software/nosql/pom.xml ---
@@ -159,5 +159,23 @@
<scope>test</scope>
</dependency>
</dependencies>
-
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <version>0.10</version>
+ <configuration>
+ <excludes combine.children="append">
+ <exclude>**/couchdb/couch.uri</exclude>
+ <exclude>**/riak/vm.args</exclude>
--- End diff --
@richardcloudsoft comments on excluding these? For `couch.uri`, the note at the top says `##### Brooklyn note: File from OSX distribution of Riak 1.4.8`. What are the implications of that?! We certainly can't claim license as apache.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn 20 apache rat
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/49#issuecomment-48447008
Thanks @Nakomis, I have merged #43 so can you rebase this PR against master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---