Re: [PR] DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" [kafka]

["mjsax (via GitHub)" <gi...@apache.org>]

mjsax commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2162781874


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImpl.java:
##########
@@ -45,28 +45,28 @@ class KGroupedStreamImpl<K, V> extends AbstractStream<K, V> implements KGroupedS
     static final String AGGREGATE_NAME = "KSTREAM-AGGREGATE-";
 
     private final GroupedStreamAggregateBuilder<K, V> aggregateBuilder;
-    final boolean repartitionRequired;
     final String userProvidedRepartitionTopicName;
 
     KGroupedStreamImpl(final String name,
                        final Set<String> subTopologySourceNodes,
                        final GroupedInternal<K, V> groupedInternal,
-                       final boolean repartitionRequired,
                        final GraphNode graphNode,
                        final InternalStreamsBuilder builder) {
         super(name, groupedInternal.keySerde(), groupedInternal.valueSerde(), subTopologySourceNodes, graphNode, builder);
-        this.repartitionRequired = repartitionRequired;
         this.userProvidedRepartitionTopicName = groupedInternal.name();
         this.aggregateBuilder = new GroupedStreamAggregateBuilder<>(
             builder,
             groupedInternal,
-            repartitionRequired,
             subTopologySourceNodes,
             name,
             graphNode
         );
     }
 
+    public boolean repartitionRequired() {
+        return builder.isRepartitionRequired(graphNode);

Review Comment:
   Cf my commend above. This could be `graphNode.repartitionRequired()` if we move the method. Or do I miss something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org