You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mosermw <gi...@git.apache.org> on 2017/02/07 19:23:10 UTC

[GitHub] nifi issue #1475: NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatExce...

Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/1475
  
    New getCharsInUTF8Limit() function looks good to me.  Sorry about missing the license concern on the last PR.
    
    PR executes as expected.  The WARN log message says "Truncating repository record value for field 'Attribute Value'!"  when an attribute value exceeds 65535 bytes.  Unfortunately, the actual name of the attribute is not available unless you go several levels up the stack.  Is this good enough or do you want to throw an exception higher up the stack to make that available?
    
    +1 looks good to me.  I will let another review and merge, to get more eyes on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---