You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "daesung9511 (via GitHub)" <gi...@apache.org> on 2025/06/25 06:49:42 UTC
[PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
daesung9511 opened a new pull request, #52224:
URL: https://github.com/apache/airflow/pull/52224
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
---
**Fix PostgresHook.get_df() warning when using non-SQLAlchemy connections**
This PR updates the `PostgresHook.get_df()` implementation to avoid triggering a `UserWarning` from pandas when the underlying connection is not an instance of `sqlalchemy.engine.Connection`. The patch ensures better compatibility with non-SQLAlchemy connections and avoids log clutter during DAG execution.
This change only affects the Postgres provider and does not alter the interface or behavior for existing users using SQLAlchemy-compatible connections.
closes: #52142
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2175414078
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +180,42 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def get_df(
+ self,
+ sqls: str | list[str],
+ parameters: list | tuple | Mapping[str, Any] | None = None,
+ *,
+ df_type: Literal["pandas", "polars"] = "pandas",
+ **kwargs,
+ ) -> PandasDataFrame | PolarsDataFrame:
+ """
+ Execute the sql and returns a dataframe.
Review Comment:
Maybe good to mention what type of dataframes it returns and add `:return ...: ...` as well into the doc :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3019749068
Thanks for the updates!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2186176634
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +180,42 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def get_df(
+ self,
+ sqls: str | list[str],
+ parameters: list | tuple | Mapping[str, Any] | None = None,
+ *,
+ df_type: Literal["pandas", "polars"] = "pandas",
+ **kwargs,
+ ) -> PandasDataFrame | PolarsDataFrame:
+ """
+ Execute the sql and returns a dataframe.
Review Comment:
Yes, I’ve added the return type to the docstring and included a unit test for get_df. Thank you for your review and guidance! Please let me know if there’s anything else I should fix.
@bugraoz93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2166846691
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
+ self,
+ sql,
+ parameters: list | tuple | Mapping[str, Any] | None = None,
+ **kwargs,
+ ) -> PandasDataFrame:
+ try:
+ from pandas.io import sql as psql
+ except ImportError:
+ raise AirflowOptionalProviderFeatureException(
+ "pandas library not installed, run: pip install "
+ "'apache-airflow-providers-common-sql[pandas]'."
+ )
Review Comment:
Not sure if we want this part…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2167884223
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
Hi, thanks for the review!
I went with this approach because it seemed like the safest option, as I’m overriding a method from the superclass 'DbApiHook'. Since the base class calls this method internally, changing its name would break the behavior. I understand that overriding protected methods isn’t generally recommended, so if there’s a better approach, I’m happy to consider it.
I also noticed that '_serialize_cell' is overridden in this class as well, so I followed that pattern for consistency.
Any suggestions or feedback are more than welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2167048145
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
+ self,
+ sql,
Review Comment:
I think this seems shadow naming with below import, could cause problems even though you added as psql there
`from pandas.io import sql as psql`
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
```suggestion
def get_pandas_df(
```
I think this shouldn't be private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2167884223
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
Hi, thanks for the review!
I went with this approach because it seemed like the safest option, as I’m overriding a method from the superclass 'DbApiHook'. Since the base class calls this method internally, changing its name would break the behavior. I understand that overriding protected methods isn’t generally recommended, so if there’s a better approach, I’m happy to consider it.
I also noticed that '_serialize_cell' is overridden in this class as well, so I followed that pattern for consistency.
Any suggestions or feedback are more than welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3079706147
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3079768398
Thank you so much! This was a wonderful experience!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3057861212
I think CI needs some love on tests :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3003576716
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2166846691
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
+ self,
+ sql,
+ parameters: list | tuple | Mapping[str, Any] | None = None,
+ **kwargs,
+ ) -> PandasDataFrame:
+ try:
+ from pandas.io import sql as psql
+ except ImportError:
+ raise AirflowOptionalProviderFeatureException(
+ "pandas library not installed, run: pip install "
+ "'apache-airflow-providers-common-sql[pandas]'."
+ )
Review Comment:
Not sure if we want this part…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3079707274
Congratulations @daesung9511 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2174244302
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
Hi, I’ve updated the code based on your feedback. Since the method you pointed out is a private one from the parent DbApiHook, I avoided modifying it directly. Instead, I reimplemented get_df here and used the private method only for the Polars case. Let me know if you’d recommend a different approach. I’ll also add unit tests for this soon
@bugraoz93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2167884223
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
Hi, thanks for the review!
I went with this approach because it seemed like the safest option, as I’m overriding a method from the superclass 'DbApiHook'. Since the base class calls this method internally, changing its name would break the behavior. I understand that overriding protected methods isn’t generally recommended, so if there’s a better approach, I’m happy to consider it.
I also noticed that '_serialize_cell' is overridden in this class as well, so I followed that pattern for consistency.
Any suggestions or feedback are more than welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3079404517
After CI fully green, I am going to merge it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3079512431
Gotcha Thank you for your review and guidance! I learned a lot through this contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3073905121
Thanks a lot @daesung9511! Could you please rebase the branch for a cleaner commit history? I believe it is always merged with the incoming changes. I think we can merge it afterwards. Great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3057670931
Let's see if CI agrees :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2174244302
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
Hi, I’ve updated the code based on your feedback. Since the method you pointed out is a private one from the parent DbApiHook, I avoided modifying it directly. Instead, I reimplemented get_df here and used the private method only for the Polars case. Let me know if you’d recommend a different approach. I’ll also add unit tests for this soon
@bugraoz93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on code in PR #52224:
URL: https://github.com/apache/airflow/pull/52224#discussion_r2174244302
##########
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py:
##########
@@ -173,6 +178,24 @@ def get_conn(self) -> connection:
self.conn = psycopg2.connect(**conn_args)
return self.conn
+ def _get_pandas_df(
Review Comment:
Hi, I’ve updated the code based on your feedback. Since the method you pointed out is a private one from the parent DbApiHook, I avoided modifying it directly. Instead, I reimplemented get_df here and used the private method only for the Polars case. Let me know if you’d recommend a different approach. I’ll also add unit tests for this once it’s approved.
@bugraoz93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3070904873
Hi, I modified the pyproject.toml and rolled back the code to ensure it passes with the minimal required dependencies and aligns the method signature with its superclass, as required by mypy in the unit tests.
Please let me know if anything should be further modified or removed. Otherwise, it looks like the CI has passed.
Thanks again for your time and review! @bugraoz93 @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 merged PR #52224:
URL: https://github.com/apache/airflow/pull/52224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3057858188
> Hi, just a kind reminder for the review. I’m here and ready to hear your advice and revise the code. Thanks!
> @bugraoz93
Thanks for the changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning [airflow]
Posted by "daesung9511 (via GitHub)" <gi...@apache.org>.
daesung9511 commented on PR #52224:
URL: https://github.com/apache/airflow/pull/52224#issuecomment-3053994703
Hi, just a kind reminder for the review. I’m here and ready to hear your advice and revise the code. Thanks!
@bugraoz93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org