You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2006/05/14 22:47:44 UTC

svn commit: r406427 - /jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/visualizers/SamplingStatCalculator.java

Author: sebb
Date: Sun May 14 13:47:44 2006
New Revision: 406427

URL: http://svn.apache.org/viewcvs?rev=406427&view=rev
Log:
Simplify startTime setting; document badly named method

Modified:
    jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/visualizers/SamplingStatCalculator.java

Modified: jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/visualizers/SamplingStatCalculator.java
URL: http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/visualizers/SamplingStatCalculator.java?rev=406427&r1=406426&r2=406427&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/visualizers/SamplingStatCalculator.java (original)
+++ jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/visualizers/SamplingStatCalculator.java Sun May 14 13:47:44 2006
@@ -178,9 +178,11 @@
 	}
 
 	/**
-	 * calculates the average page size, which means divide the bytes by number
-	 * of samples.
+	 * Should calculate the average page size, which means divide the bytes by number
+	 * of samples - actually calculates the throughput in bytes / second
 	 * 
+     * TODO - fix the name and comment
+     * 
 	 * @return
 	 */
 	public double getPageSize() {
@@ -195,7 +197,7 @@
 	}
 
 	/**
-	 * formats the rate
+	 * formats the Page Size
 	 * 
 	 * @return
 	 */
@@ -290,10 +292,7 @@
 	 * @param res
 	 */
 	private void setStartTime(SampleResult res) {
-		long startTime = res.getTimeStamp();
-		if (!res.isStampedAtStart()) {
-			startTime -= res.getTime();
-		}
+		long startTime = res.getStartTime();
 		if (firstTime > startTime) {
 			// this is our first sample, set the start time to current timestamp
 			firstTime = startTime;



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org