[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1000: MINIFICPP-1451: ThreadPoolAdjust test transiently failed on Windows CI

[GitBox <gi...@apache.org>]

martinzink commented on a change in pull request #1000:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1000#discussion_r573587229



##########
File path: extensions/http-curl/tests/ThreadPoolAdjust.cpp
##########
@@ -31,9 +31,11 @@
 #include "processors/LogAttribute.h"
 #include "utils/IntegrationTestUtils.h"
 
+constexpr uint64_t INCREASED_WAITTIME_MSECS = DEFAULT_WAITTIME_MSECS * 1.5;
+
 class HttpTestHarness : public IntegrationBase {
  public:
-  HttpTestHarness() {
+  HttpTestHarness() : IntegrationBase(INCREASED_WAITTIME_MSECS) {

Review comment:
       Looking at the available logs on github, this issue is fairly regular (happened 7 times in the last 90 days, only on windows)
   
   The strange thing is, usually by the time the assertion message appears the required log lines are already present.
   So I suspected that the given wait time for these log messages are too low to be consistent for the windows CI. (I wasn't able to reproduce the issue on my windows machine)
   I've tested the fix with a custom CI that's tries to run this test 200 times on windows2017 and windows2019.
   Without the fix it wasn't able to run the 200 test run without failure 4 times out of 4. (Failures happened after the 1st, 11th, 12th, 103rd test run)
     https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551019180
     https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551315036
   With the increased wait time it passed 6 times out of 6. (1200 successful test run)
     https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551722774
     https://github.com/martinzink/nifi-minifi-cpp/actions/runs/552033701
     https://github.com/martinzink/nifi-minifi-cpp/actions/runs/552535235




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org