[GitHub] trafficserver pull request: TS-4165 Logging breaks if changing log...

[SolidWallOfCode <gi...@git.apache.org>]

Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/446#discussion_r51428533
  
    --- Diff: proxy/logging/LogObject.cc ---
    @@ -1043,6 +1044,15 @@ LogObjectManager::_solve_filename_conflicts(LogObject *log_object, int maxConfli
       return retVal;
     }
     
    +void
    +LogObjectManager::_filename_resolution_abort(const char *filename)
    +{
    +  const char *msg = "Cannot roll log file %s to fix log "
    +                    "conflicts (filename or log format)";
    +  Error(msg, filename);
    --- End diff --
    
    Can we get errno and strerr() in here as well? That would be good.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---