[jira] Updated: (SHINDIG-1011) Proxied image resizing

["Filip Miletic (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Filip Miletic updated SHINDIG-1011:
-----------------------------------

    Attachment: shindig-proxied-image-resizing.diff

Corrections after the second round of code review.

o Reinforce the image rewriter tests.
o Corrected the parameter reading.
o Ignore the unusable parameters.
o Modifies getOwnerId() and related methods
The old behavior of AbstractHttpCache.getOwnerId() was to return
ownerId as-is.  Since ownerId may be null, this amounted to inserting
a literal "null" in the cache key.  As we probably don't want that
(it's colliding with the owner id which in fact is "null"), the
getOwnerId(HttpRequest) now returns an empty string literal for a null
owner ID.

The code and cleanup to support proxied image resizing.
Based on the initial work of Paul Lindner of Hi5.  His work in turn is
based on further contributions, but I don't know at present which ones.

o Reorganized the image rewriter implementation from Paul, and corrected
a few bugs in the image dimensions computation.
o A few readability changes.
o Verified new behavior and added the tests to guard against accidental
further behavior changes.
o Modified the caching policy to take into account the resizing URL
arguments required for resizing to work.
o Factored the cache key building into a builder class that ensures
backward compatibility of the generated cache keys, and makes building
cache keys easier in general.
o Added the tests to guard against accidental behavior changes in the
cache key builder.
o Fitted all the pieces back together again.


> Proxied image resizing
> ----------------------
>
>                 Key: SHINDIG-1011
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1011
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Java
>    Affects Versions: trunk
>            Reporter: Filip Miletic
>         Attachments: shindig-proxied-image-resizing.diff
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.