You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2019/06/26 01:18:55 UTC

[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API

Fang-Yu Rao has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13346 )

Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
......................................................................

IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API

Impala uses a workaround to detect if a user is a Sentry admin by calling
the Sentry API to list privileges associated with the user since previously
Sentry did not provide a suitable API to peform this check.
This patch invokes a new API in SENTRY-2440 to perform the Sentry admin check.

Also modified test_sentry.py to exercise the code paths corresponding to the
following 3 different types of users: (i) a Sentry admin, (ii) an existing
user which is not a Sentry admin, and (iii) a non-existing user.

Testing:
1. Passed the tests in the revised test_sentry.py.

Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82
---
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryPolicyService.java
M fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/authorization/test_sentry.py
5 files changed, 62 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/13346/10
-- 
To view, visit http://gerrit.cloudera.org:8080/13346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82
Gerrit-Change-Number: 13346
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>