You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Prabhjyot Singh <pr...@gmail.com> on 2017/02/08 11:40:53 UTC
Review Request 56439: spark/livy (1.x) should not be configured in
Zeppelin's interpreter if they are not installed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
Bugs: AMBARI-19919
https://issues.apache.org/jira/browse/AMBARI-19919
Repository: ambari
Description
-------
spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed.
Also, if Spark2 and/or livy2 is available that should be configured by default as well.
Diffs
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 9af48e5
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 97e93fe
Diff: https://reviews.apache.org/r/56439/diff/
Testing
-------
tested manually on Centos6.4
Thanks,
Prabhjyot Singh
Re: Review Request 56439: spark/livy (1.x) should not be configured in
Zeppelin's interpreter if they are not installed
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164869
-----------------------------------------------------------
Ship it!
Ship It!
- Renjith Kamath
On Feb. 8, 2017, 5:04 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 5:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by default as well.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 9af48e5
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 97e93fe
>
> Diff: https://reviews.apache.org/r/56439/diff/
>
>
> Testing
> -------
>
> tested manually on Centos6.4
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56439: spark/livy (1.x) should not be configured in
Zeppelin's interpreter if they are not installed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164724
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 8, 2017, 5:04 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 5:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by default as well.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 9af48e5
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 97e93fe
>
> Diff: https://reviews.apache.org/r/56439/diff/
>
>
> Testing
> -------
>
> tested manually on Centos6.4
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56439: spark/livy (1.x) should not be configured in
Zeppelin's interpreter if they are not installed
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164769
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Feb. 8, 2017, 5:04 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 5:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by default as well.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 9af48e5
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 97e93fe
>
> Diff: https://reviews.apache.org/r/56439/diff/
>
>
> Testing
> -------
>
> tested manually on Centos6.4
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56439: spark/livy (1.x) should not be configured in
Zeppelin's interpreter if they are not installed
Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 5:04 p.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
Bugs: AMBARI-19919
https://issues.apache.org/jira/browse/AMBARI-19919
Repository: ambari
Description
-------
spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed.
Also, if Spark2 and/or livy2 is available that should be configured by default as well.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 9af48e5
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 97e93fe
Diff: https://reviews.apache.org/r/56439/diff/
Testing
-------
tested manually on Centos6.4
Thanks,
Prabhjyot Singh
Re: Review Request 56439: spark/livy (1.x) should not be configured in
Zeppelin's interpreter if they are not installed
Posted by Prabhjyot Singh <pr...@gmail.com>.
> On Feb. 8, 2017, 3:30 p.m., Renjith Kamath wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py, line 336
> > <https://reviews.apache.org/r/56439/diff/1/?file=1627589#file1627589line336>
> >
> > Livy is not always present, need a check for livy host.
> >
> > error when livy is not installed:
> > ```
> > File "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py", line 339, in update_zeppelin_interpreter
> > ":" + params.livy_livyserver_port
> > TypeError: cannot concatenate 'str' and 'NoneType' objects
> > ```
Sure, have update the diff.
- Prabhjyot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164694
-----------------------------------------------------------
On Feb. 8, 2017, 5:04 p.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 5:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by default as well.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 9af48e5
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 97e93fe
>
> Diff: https://reviews.apache.org/r/56439/diff/
>
>
> Testing
> -------
>
> tested manually on Centos6.4
>
>
> Thanks,
>
> Prabhjyot Singh
>
>
Re: Review Request 56439: spark/livy (1.x) should not be configured in
Zeppelin's interpreter if they are not installed
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56439/#review164694
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py (line 336)
<https://reviews.apache.org/r/56439/#comment236459>
Livy is not always present, need a check for livy host.
error when livy is not installed:
```
File "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py", line 339, in update_zeppelin_interpreter
":" + params.livy_livyserver_port
TypeError: cannot concatenate 'str' and 'NoneType' objects
```
- Renjith Kamath
On Feb. 8, 2017, 11:40 a.m., Prabhjyot Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56439/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 11:40 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19919
> https://issues.apache.org/jira/browse/AMBARI-19919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed.
> Also, if Spark2 and/or livy2 is available that should be configured by default as well.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py 9af48e5
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py 97e93fe
>
> Diff: https://reviews.apache.org/r/56439/diff/
>
>
> Testing
> -------
>
> tested manually on Centos6.4
>
>
> Thanks,
>
> Prabhjyot Singh
>
>