You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com> on 2016/05/26 20:10:14 UTC

Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 

Diff: https://reviews.apache.org/r/47916/diff/


Testing
-------


Thanks,

Hari Sankar Sivarama Subramaniyan

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/#review135068
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2889)
<https://reviews.apache.org/r/47916/#comment200045>

    ah makes sense. Thanks.


- Hari Sankar Sivarama Subramaniyan


On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47916/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 8:10 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 
> 
> Diff: https://reviews.apache.org/r/47916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/#review135063
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2889)
<https://reviews.apache.org/r/47916/#comment200040>

    Do you mean to say destFs.getFileStatus(destf) is incorrect here. If so, which object should I use.


- Hari Sankar Sivarama Subramaniyan


On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47916/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 8:10 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 
> 
> Diff: https://reviews.apache.org/r/47916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Ashutosh Chauhan <ha...@apache.org>.

> On May 26, 2016, 8:57 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2889
> > <https://reviews.apache.org/r/47916/diff/1/?file=1395707#file1395707line2889>
> >
> >     As i mentioned satus

Your first patch was using it. Was there any problem you reverted it ?


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/#review135065
-----------------------------------------------------------


On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47916/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 8:10 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 
> 
> Diff: https://reviews.apache.org/r/47916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/#review135065
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2889)
<https://reviews.apache.org/r/47916/#comment200042>

    As i mentioned satus


- Ashutosh Chauhan


On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47916/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 8:10 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 
> 
> Diff: https://reviews.apache.org/r/47916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/#review135060
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2889)
<https://reviews.apache.org/r/47916/#comment200035>

    you can use status object here..



shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java (line 120)
<https://reviews.apache.org/r/47916/#comment200036>

    You may want to have group.equals(targetStatus.getGroup()) to protect against NPE in case targetStatus.getGroup() returns null.


- Ashutosh Chauhan


On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47916/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 8:10 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 
> 
> Diff: https://reviews.apache.org/r/47916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/
-----------------------------------------------------------

(Updated May 27, 2016, 9:50 p.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java bc39994 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 379eddc 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 

Diff: https://reviews.apache.org/r/47916/diff/


Testing
-------


Thanks,

Hari Sankar Sivarama Subramaniyan

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/#review135325
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (lines 2867 - 2876)
<https://reviews.apache.org/r/47916/#comment200349>

    I don't think this is needed. This codepath gets exercised when dest is pre-existing. There is no need to set permissions in that case.


- Ashutosh Chauhan


On May 27, 2016, 7:42 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47916/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 7:42 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 717589a 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 
> 
> Diff: https://reviews.apache.org/r/47916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/
-----------------------------------------------------------

(Updated May 27, 2016, 7:42 p.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 717589a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 

Diff: https://reviews.apache.org/r/47916/diff/


Testing
-------


Thanks,

Hari Sankar Sivarama Subramaniyan

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/
-----------------------------------------------------------

(Updated May 26, 2016, 9:28 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Missed out uploading the missing callsite changes in the previous one.


Repository: hive-git


Description
-------

insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 717589a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 

Diff: https://reviews.apache.org/r/47916/diff/


Testing
-------


Thanks,

Hari Sankar Sivarama Subramaniyan

Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II

Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47916/
-----------------------------------------------------------

(Updated May 26, 2016, 9:14 p.m.)


Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc 

Diff: https://reviews.apache.org/r/47916/diff/


Testing
-------


Thanks,

Hari Sankar Sivarama Subramaniyan