You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "gnehil (via GitHub)" <gi...@apache.org> on 2023/04/06 09:59:47 UTC
[GitHub] [doris] gnehil opened a new pull request, #18438: [fix](es) ClassCastException when getting root schema
gnehil opened a new pull request, #18438:
URL: https://github.com/apache/doris/pull/18438
# Proposed changes
Issue Number: close #xxx
## Problem summary
When the dynamic parameter in the mapping is set to null, getting the root schema will cause ClassCastException
example:
```json
{
"test_index": {
"mappings": {
"dynamic": "false",
"properties": {
"time": {
"type": "long"
},
"type": {
"type": "keyword"
},
"userId": {
"type": "text",
"fields": {
"keyword": {
"type": "keyword"
}
}
}
}
}
}
}
```
When the mapping structure is as above
The exception that occurs in the latest version is `java.lang.ClassCastException: com.fasterxml.jackson.databind.node.TextNode cannot be cast to com.fasterxml.jackson.databind.node.ObjectNode`,
and for elder version is `java.lang.ClassCastException: java.lang.String cannot be cast to org.json.simple.JSONObject`
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #18438: [fix](es) ClassCastException when getting root schema
Posted by "stalary (via GitHub)" <gi...@apache.org>.
stalary commented on PR #18438:
URL: https://github.com/apache/doris/pull/18438#issuecomment-1500755041
It can resolve this problem in this pr https://github.com/apache/doris/pull/18382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #18438: [fix](es) ClassCastException when getting root schema
Posted by "stalary (via GitHub)" <gi...@apache.org>.
stalary commented on PR #18438:
URL: https://github.com/apache/doris/pull/18438#issuecomment-1501303722
> I think we are not having the same problem. The problem I have encountered is that when calling the `getRootSchema` method, when the `mappingType` is null and there is `dynamic` parameter in the mapping json, since the first element obtained by traversing the mapping json through the iterator is `dynamic`, and its type is `TextNode`, a `ClassCastException` will appear when running the following code：
>
> ```java
> ObjectNode firstData = (ObjectNode) mappings.get(firstType);
> ```
>
> All this happens before calling the `replaceFieldAlias` method.
Okey, I get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #18438: [fix](es) ClassCastException when getting root schema
Posted by "stalary (via GitHub)" <gi...@apache.org>.
stalary commented on PR #18438:
URL: https://github.com/apache/doris/pull/18438#issuecomment-1501304572
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18438: [fix](es) ClassCastException when getting root schema
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18438:
URL: https://github.com/apache/doris/pull/18438#issuecomment-1501305493
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gnehil commented on pull request #18438: [fix](es) ClassCastException when getting root schema
Posted by "gnehil (via GitHub)" <gi...@apache.org>.
gnehil commented on PR #18438:
URL: https://github.com/apache/doris/pull/18438#issuecomment-1501042570
I think we are not having the same problem.
The problem I have encountered is that when calling the `getRootSchema` method, when the `mappingType` is null and there is `dynamic` parameter in the mapping json, since the first element obtained by traversing the mapping json through the iterator is `dynamic`, and its type is `TextNode`, a `ClassCastException` will appear when running the following code：
```java
ObjectNode firstData = (ObjectNode) mappings.get(firstType);
```
All this happens before calling the `replaceFieldAlias` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18438: [fix](es) ClassCastException when getting root schema
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18438:
URL: https://github.com/apache/doris/pull/18438#issuecomment-1501305456
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary merged pull request #18438: [fix](es) ClassCastException when getting root schema
Posted by "stalary (via GitHub)" <gi...@apache.org>.
stalary merged PR #18438:
URL: https://github.com/apache/doris/pull/18438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org