You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by Todd Volkert <tv...@gmail.com> on 2010/08/02 17:24:23 UTC

[VOTE] Release Pivot 1.5.1

All:

The Pivot 1.5.1 release candidate has been tagged, packaged, and is
ready for a vote. The artifacts, RAT reports, and KEYS file can be
found at http://people.apache.org/~tvolkert/dist/pivot/v1.5.1/.  The
tag from which the release artifacts were generated can be found at
http://svn.apache.org/repos/asf/pivot/tags/v1.5.1/.

In addition, my PGP public code signing key can be found at the MIT
key server (http://pgp.mit.edu/) and The SKS key server
(http://www.pramberger.at/peter/services/keyserver/).

Please vote to publish this release by Thursday, August 5 20:00 GMT.

In your vote, please include the testing you performed to arrive at your vote.

[  ] +1 Publish
[  ] +0
[  ] -0
[  ] -1 Don't publish

Thanks,
-T

[Cancelled] [VOTE] Release Pivot 1.5.1

Posted by Todd Volkert <tv...@gmail.com>.
Canceling to pick up Greg's fixes to the issue Sandro discovered.

-T

Re: [VOTE] Release Pivot 1.5.1

Posted by Greg Brown <gk...@mac.com>.
OK - the CSVSerializer issue is now fixed, as is the Maven issue. Let's re-tag and regenerate the build - we can do another vote as soon as it is ready.

Thanks Sandro!

On Aug 5, 2010, at 5:53 PM, Sandro Martini wrote:

> Hi to all,
> sorry for the delay but I was in bed with flu ...
> 
> My vote is:
> [-1] Don't publish
> 
> because of the error in tests, my fear is that some other small
> problem is in this release.
> 
> 
> These are my tests:
> 
> 
> Test platform: Windows 7 at 64 bit, Sun JDK 6 Update 21 (64 bit), and
> Java Runtime 6 Update 21 (32 bit) inside Firefox 3.6.8
> 
> - checked md5 on apache-pivot-1.5.1.zip
> 
> - checked that root files are good (README, LICENSE, etc)
>  Note that in the README probably this link should be upgraded (or
> put there the 1.5.1) docs:
>  Javadoc:         http://pivot.apache.org/1.5/docs/api/
> 
> - opened and inspected all pivot jars to ensure the content is right,
> and check that new files under meta-inf are present
> - opened javadoc index, and tested some random pages
> - deploy demos and tutorials wars in a local tomcat 6.0.28 instance,
>  and verify that the two web applications are working, that all links
> are good (pages, applets, web start applications),
>  and that all pages have the right content inside
> 
> 
> 
> Test platform: Windows 7 at 64 bit, Sun JDK 6 Update 21 (64 bit), and
> Java Runtime 6 Update 21 (32 bit) inside Firefox 3.6.8
> 
> - checked md5 on apache-pivot-1.5.1-src.zip
> 
> - checked that root files are good (README, LICENSE, etc)
>  Note that in the README probably this link should be upgraded (or
> put there the 1.5.1) docs:
>  Javadoc:         http://pivot.apache.org/1.5/docs/api/
> 
> - setup environment: using ant-1.8.1, junit-4.8.1 and maven-ant-task-2.1.0
> 
> 
> - run many ant commands: clean, doc, test, clean, dist, install,
> maven-install, and ensure that all works good
> 
> Note that ant test gave me this:
> test:
>     [echo] core: Executing test cases...
>    [junit] Test org.apache.pivot.serialization.test.CSVSerializerTest FAILED
>     [echo] web: Executing test cases...
> 
> More in detail, the error is in this method:
>    public void testQuotedNewlineReadObject() throws IOException,
> SerializationException {
> 	
> 
> - inspected generated artifacts (zip, jars)
> 
> 
> NOTE: I'm sorry for this vote but I think that some other day could
> help to fix these small issues (and the maven little problems as seen
> by Greg).
> 
> Bye,
> Sandro


Re: [VOTE] Release Pivot 1.5.1

Posted by Sandro Martini <sa...@gmail.com>.
Hi to all,
sorry for the delay but I was in bed with flu ...

My vote is:
[-1] Don't publish

because of the error in tests, my fear is that some other small
problem is in this release.


These are my tests:


Test platform: Windows 7 at 64 bit, Sun JDK 6 Update 21 (64 bit), and
Java Runtime 6 Update 21 (32 bit) inside Firefox 3.6.8

- checked md5 on apache-pivot-1.5.1.zip

- checked that root files are good (README, LICENSE, etc)
  Note that in the README probably this link should be upgraded (or
put there the 1.5.1) docs:
  Javadoc:         http://pivot.apache.org/1.5/docs/api/

- opened and inspected all pivot jars to ensure the content is right,
and check that new files under meta-inf are present
- opened javadoc index, and tested some random pages
- deploy demos and tutorials wars in a local tomcat 6.0.28 instance,
  and verify that the two web applications are working, that all links
are good (pages, applets, web start applications),
  and that all pages have the right content inside



Test platform: Windows 7 at 64 bit, Sun JDK 6 Update 21 (64 bit), and
Java Runtime 6 Update 21 (32 bit) inside Firefox 3.6.8

- checked md5 on apache-pivot-1.5.1-src.zip

- checked that root files are good (README, LICENSE, etc)
  Note that in the README probably this link should be upgraded (or
put there the 1.5.1) docs:
  Javadoc:         http://pivot.apache.org/1.5/docs/api/

- setup environment: using ant-1.8.1, junit-4.8.1 and maven-ant-task-2.1.0


- run many ant commands: clean, doc, test, clean, dist, install,
maven-install, and ensure that all works good

Note that ant test gave me this:
test:
     [echo] core: Executing test cases...
    [junit] Test org.apache.pivot.serialization.test.CSVSerializerTest FAILED
     [echo] web: Executing test cases...

More in detail, the error is in this method:
    public void testQuotedNewlineReadObject() throws IOException,
SerializationException {
	

- inspected generated artifacts (zip, jars)


NOTE: I'm sorry for this vote but I think that some other day could
help to fix these small issues (and the maven little problems as seen
by Greg).

Bye,
Sandro

Re: [VOTE] Release Pivot 1.5.1

Posted by Greg Brown <gk...@mac.com>.
> [x] +1 Publish

- Reviewed RAT report
- Reviewed release notes

- Downloaded apache-pivot-1.5.1.tar.gz
- Verified MD5 checksum
- Expanded archive
- Reviewed LICENSE
- Reviewed NOTICE
- Reviewed README
- Reviewed RELEASE-NOTES
- Reviewed Javadoc
- Installed demo and tutorial WARs in Tomcat 6.0.24
- Cleared browser cache and Java application cache
- Launched Kitchen Sink demo
- Launched Stock Tracker demo
- Launched Component Explorer demo
- Launched several tutorial examples, including the new QueryServlet tutorial

- Downloaded apache-pivot-1.5.1-src.tar.gz
- Verified MD5 checksum
- Expanded archive
- Reviewed BUILD
- Ran install target
- Verified correct generation of all release artifacts

- Downloaded apache-pivot-1.5.1.zip
- Verified MD5 checksum
- Expanded archive and verified expected file contents

- Downloaded apache-pivot-1.5.1-src.zip
- Verified MD5 checksum
- Expanded archive and ran default build target

- Uploaded Maven bundles to staging repository

NOTES:
- Some Javadoc was missing for classes in org.apache.pivot.wtkx that were made public for this release, but I don't think that is a showstopper. These classes are again private in Pivot 2.0, so it is already a non-issue.

- There is an error in the POM file for pivot-web-server-1.5.1-bundle.zip, so this bundle can't be deployed to the central Maven repo. This is unfortunate, but again I don't think it should be a showstopper (I have already fixed it in trunk and 1.5.x).