You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/26 01:54:17 UTC

[GitHub] [pulsar] Jason918 commented on a diff in pull request #16781: [improve] [admin] [PIP-179] Dynamic configuration for check unknown request parameters

Jason918 commented on code in PR #16781:
URL: https://github.com/apache/pulsar/pull/16781#discussion_r929455391


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -1487,6 +1487,13 @@ public class ServiceConfiguration implements PulsarConfiguration {
         )
     private double httpRequestsMaxPerSecond = 100.0;
 
+    @FieldContext(
+            category =  CATEGORY_HTTP,
+            dynamic = true,
+            doc = "Admin API fail on unknown request parameter in request-body. see PIP-178. Default false."

Review Comment:
   It's PIP-179 in the title of this PR. which is right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org