You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/18 02:40:50 UTC
[GitHub] [incubator-tvm] mikeseven opened a new issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited
mikeseven opened a new issue #6090:
URL: https://github.com/apache/incubator-tvm/issues/6090
Using the test_pass_partition_graph.py and whitelisting nn.conv2d to be built with ccompiler crashes in codegen.cc because it seems to support only the simple operations in this test!
Seems like ccompiler codegen is just a test itself???
Bummer, it would have been great to test separate compilation of real NN operators as a fallback mechanism on CPU if external compiler like DNNL are not available or not supporting an operation.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on issue #6090:
URL: https://github.com/apache/incubator-tvm/issues/6090#issuecomment-662585519
Having a small script to reproduce the bug would be helpful, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mikeseven commented on issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited
Posted by GitBox <gi...@apache.org>.
mikeseven commented on issue #6090:
URL: https://github.com/apache/incubator-tvm/issues/6090#issuecomment-663885841
ah ok, make sense now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited
Posted by GitBox <gi...@apache.org>.
comaniac commented on issue #6090:
URL: https://github.com/apache/incubator-tvm/issues/6090#issuecomment-660422421
Could you provide more details for the crashing you encountered? DNNL codegen is mainly for BYOC demonstration purpose and it's not in production for now.
On the other hand, BYOC does have the mechanism to offload supported ops to the external codegen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mikeseven commented on issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited
Posted by GitBox <gi...@apache.org>.
mikeseven commented on issue #6090:
URL: https://github.com/apache/incubator-tvm/issues/6090#issuecomment-662860171
The script is simply test_pass_partition_graph.py is TVM tests.
Replacing `mod=WhiteListAnnotator(["add","substract","multiply"], "ccompiler")(mod)`
with `mod=WhiteListAnnotator(["nn.conv2d"], "ccompiler")(mod)`
Then simply calling `relay.build(mod, target, params)`
Crash happens because it only knows about add, substract, multiply and nothing else.
```
File "../src/relay/backend/contrib/codegen_c/codegen.cc", line 124
TVMError: Unrecognized op
```
I was under the assumption that using ccompiler would reuse TVM for x86 on the subgraph, similar to what on_device() does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mikeseven closed issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited
Posted by GitBox <gi...@apache.org>.
mikeseven closed issue #6090:
URL: https://github.com/apache/incubator-tvm/issues/6090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on issue #6090: [BUG] PartitionGraph and ccompiler too simplistic, too limited
Posted by GitBox <gi...@apache.org>.
comaniac commented on issue #6090:
URL: https://github.com/apache/incubator-tvm/issues/6090#issuecomment-663080925
The message you posted is expected. `ccompiler` is only used for demonstration purpose, and we don't expect to suppose more ops for it. The fallback mechanism on CPU is to use the LLVM backend instead directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org