[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #603: [#291] feat: Support async read

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #603:
URL: https://github.com/apache/incubator-uniffle/pull/603#discussion_r1130616821


##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java:
##########
@@ -89,8 +89,10 @@ public ShuffleDataResult readShuffleData() {
       blocksOfSegment.and(expectBlockIds);
       if (!blocksOfSegment.isEmpty()) {
         // skip processed blockIds
-        blocksOfSegment.or(processBlockIds);
-        blocksOfSegment.xor(processBlockIds);
+        synchronized (processBlockIds) {

Review Comment:
   I didn't look it carefully. Let me do some investigation work first, then come back to this thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org