[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #1394: Add TIME command as Redis

["torwig (via GitHub)" <gi...@apache.org>]

torwig commented on code in PR #1394:
URL: https://github.com/apache/incubator-kvrocks/pull/1394#discussion_r1170185753


##########
src/commands/cmd_server.cc:
##########
@@ -941,6 +957,7 @@ REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandAuth>("auth", 2, "read-only ok-loadin
                         MakeCmdAttr<CommandDebug>("debug", -2, "read-only exclusive", 0, 0, 0),
                         MakeCmdAttr<CommandCommand>("command", -1, "read-only", 0, 0, 0),
                         MakeCmdAttr<CommandEcho>("echo", 2, "read-only", 0, 0, 0),
+                        MakeCmdAttr<CommandTime>("time", 1, "ok-loading", 0, 0, 0),

Review Comment:
   I think you can add `read-only` to the attributes of the `TIME` command.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org