You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/06/09 02:43:42 UTC

[PR] [SPARK-57333] Use 4.2.0 RC1 for Spark 4.2 integration tests [spark-connect-swift]

dongjoon-hyun opened a new pull request, #415:
URL: https://github.com/apache/spark-connect-swift/pull/415

   ### What changes were proposed in this pull request?
   
   This PR updates the `integration-test-mac-spark42` CI job to use `Apache Spark 4.2.0` RC1.
   
   ### Why are the changes needed?
   
   To test against the latest `Apache Spark 4.2.0` RC1.
   - https://dist.apache.org/repos/dist/dev/spark/v4.2.0-rc1-bin/
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs and check the log.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 4.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57333] Use 4.2.0 RC1 for Spark 4.2 integration tests [spark-connect-swift]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #415: [SPARK-57333] Use 4.2.0 RC1 for Spark 4.2 integration tests
URL: https://github.com/apache/spark-connect-swift/pull/415


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57333] Use 4.2.0 RC1 for Spark 4.2 integration tests [spark-connect-swift]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #415:
URL: https://github.com/apache/spark-connect-swift/pull/415#issuecomment-4655821158

   Merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57333] Use 4.2.0 RC1 for Spark 4.2 integration tests [spark-connect-swift]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #415:
URL: https://github.com/apache/spark-connect-swift/pull/415#discussion_r3377628174


##########
Tests/SparkConnectTests/Resources/queries/geography.sql.answer:
##########
@@ -1,5 +1,5 @@
-+-------------------------------------------------------------------------------+
-|hex(st_asbinary(st_geogfromwkb(X'0101000000000000000000F03F0000000000000040')))|

Review Comment:
   The generated column string is changed at RC1. So, I update the query with a column alias to be robust.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57333] Use 4.2.0 RC1 for Spark 4.2 integration tests [spark-connect-swift]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #415:
URL: https://github.com/apache/spark-connect-swift/pull/415#discussion_r3377628174


##########
Tests/SparkConnectTests/Resources/queries/geography.sql.answer:
##########
@@ -1,5 +1,5 @@
-+-------------------------------------------------------------------------------+
-|hex(st_asbinary(st_geogfromwkb(X'0101000000000000000000F03F0000000000000040')))|

Review Comment:
   The generated column string is changed at RC1. So, I update the query with a column alias to be robust.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57333] Use 4.2.0 RC1 for Spark 4.2 integration tests [spark-connect-swift]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #415:
URL: https://github.com/apache/spark-connect-swift/pull/415#issuecomment-4655793597

   Thank you, @viirya !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org