You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/01/21 01:17:13 UTC
Review Request 55811: ATLAS-1478: REST API to add classification to
multiple entities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55811/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1478
https://issues.apache.org/jira/browse/ATLAS-1478
Repository: atlas
Description
-------
added a REST API to add a classification to multiple entities (author: Vimal Sharma)
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0aae0c
intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java PRE-CREATION
release-log.txt 55ac3da
repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 886a8d1
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java b9671b2
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 8307835
server-api/src/main/java/org/apache/atlas/services/MetadataService.java e653184
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 21f8977
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 90a46f8
Diff: https://reviews.apache.org/r/55811/diff/
Testing
-------
- added unit tests
- deployed Atlas with the new API and verified via curl that the API works correctly
Thanks,
Madhan Neethiraj
Re: Review Request 55811: ATLAS-1478: REST API to add classification
to multiple entities
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55811/#review162537
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java (line 212)
<https://reviews.apache.org/r/55811/#comment233844>
I think we shouldn't use anything from the legaacy code here. ITypedStruct should be replaced by AtlasStruct.
- Apoorv Naik
On Jan. 21, 2017, 1:17 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55811/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2017, 1:17 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1478
> https://issues.apache.org/jira/browse/ATLAS-1478
>
>
> Repository: atlas
>
>
> Description
> -------
>
> added a REST API to add a classification to multiple entities (author: Vimal Sharma)
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0aae0c
> intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java PRE-CREATION
> release-log.txt 55ac3da
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 886a8d1
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java b9671b2
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 8307835
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java e653184
> webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 21f8977
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 90a46f8
>
> Diff: https://reviews.apache.org/r/55811/diff/
>
>
> Testing
> -------
>
> - added unit tests
> - deployed Atlas with the new API and verified via curl that the API works correctly
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 55811: ATLAS-1478: REST API to add classification
to multiple entities
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55811/#review162539
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java (line 212)
<https://reviews.apache.org/r/55811/#comment233847>
You are right. Once v2 implementation is in place, this will be updated to replace v1 references to v2 equivalents.
- Madhan Neethiraj
On Jan. 21, 2017, 1:17 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55811/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2017, 1:17 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1478
> https://issues.apache.org/jira/browse/ATLAS-1478
>
>
> Repository: atlas
>
>
> Description
> -------
>
> added a REST API to add a classification to multiple entities (author: Vimal Sharma)
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0aae0c
> intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java PRE-CREATION
> release-log.txt 55ac3da
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 886a8d1
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java b9671b2
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 8307835
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java e653184
> webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 21f8977
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 90a46f8
>
> Diff: https://reviews.apache.org/r/55811/diff/
>
>
> Testing
> -------
>
> - added unit tests
> - deployed Atlas with the new API and verified via curl that the API works correctly
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 55811: ATLAS-1478: REST API to add classification
to multiple entities
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55811/#review162542
-----------------------------------------------------------
Ship it!
Ship It!
- Vimal Sharma
On Jan. 21, 2017, 1:17 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55811/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2017, 1:17 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1478
> https://issues.apache.org/jira/browse/ATLAS-1478
>
>
> Repository: atlas
>
>
> Description
> -------
>
> added a REST API to add a classification to multiple entities (author: Vimal Sharma)
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0aae0c
> intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java PRE-CREATION
> release-log.txt 55ac3da
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 886a8d1
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java b9671b2
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 8307835
> server-api/src/main/java/org/apache/atlas/services/MetadataService.java e653184
> webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 21f8977
> webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 90a46f8
>
> Diff: https://reviews.apache.org/r/55811/diff/
>
>
> Testing
> -------
>
> - added unit tests
> - deployed Atlas with the new API and verified via curl that the API works correctly
>
>
> Thanks,
>
> Madhan Neethiraj
>
>