You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/03/01 06:43:04 UTC
[GitHub] [dubbo-go-pixiu] baerwang opened a new pull request #373: feat:load balancer strategy mode and add consistent hash
baerwang opened a new pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
Features
refer to #366
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d8bd18) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/f786aa8ab6e263ebceb10f45c81c0b200b41adae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f786aa8) will **decrease** coverage by `0.22%`.
> The diff coverage is `58.82%`.
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 39.61% 39.39% -0.23%
===========================================
Files 54 54
Lines 3463 3460 -3
===========================================
- Hits 1372 1363 -9
- Misses 1929 1934 +5
- Partials 162 163 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `37.06% <36.36%> (-0.32%)` | :arrow_down: |
| [pkg/adapter/xds/cds.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIveGRzL2Nkcy5nbw==) | `57.02% <100.00%> (-0.36%)` | :arrow_down: |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f786aa8...6d8bd18](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#discussion_r817352449
##########
File path: pkg/cluster/loadbalancer/consistenthashing/consistent_hash.go
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package consistenthashing
Review comment:
pls refer https://github.com/AlexStocks/goext/tree/master/hash/consistent and move it to dubbogo/gost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af0ff3e) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/246bb65fca6d5fce8b84745dc7edb67dcaff0525?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (246bb65) will **decrease** coverage by `0.22%`.
> The diff coverage is `58.82%`.
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 39.61% 39.39% -0.23%
===========================================
Files 54 54
Lines 3463 3460 -3
===========================================
- Hits 1372 1363 -9
- Misses 1929 1934 +5
- Partials 162 163 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `37.06% <36.36%> (-0.32%)` | :arrow_down: |
| [pkg/adapter/xds/cds.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIveGRzL2Nkcy5nbw==) | `57.02% <100.00%> (-0.36%)` | :arrow_down: |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [246bb65...af0ff3e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (046d3a3) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/4e636d69af69267c2bf1eeef59ad581cd0f26314?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e636d6) will **increase** coverage by `0.01%`.
> The diff coverage is `53.33%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
+ Coverage 39.27% 39.28% +0.01%
===========================================
Files 49 51 +2
Lines 3053 3098 +45
===========================================
+ Hits 1199 1217 +18
- Misses 1718 1743 +25
- Partials 136 138 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../loadbalancer/consistenthashing/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsdXN0ZXIvbG9hZGJhbGFuY2VyL2NvbnNpc3RlbnRoYXNoaW5nL2NvbnNpc3RlbnRfaGFzaC5nbw==) | `22.22% <22.22%> (ø)` | |
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `44.32% <36.36%> (-1.13%)` | :arrow_down: |
| [.../cluster/loadbalancer/consistenthashing/hashing.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsdXN0ZXIvbG9hZGJhbGFuY2VyL2NvbnNpc3RlbnRoYXNoaW5nL2hhc2hpbmcuZ28=) | `63.15% <63.15%> (ø)` | |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e636d6...046d3a3](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur commented on a change in pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
ztelur commented on a change in pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#discussion_r830455549
##########
File path: samples/dubbogo/simple/triple/docker/docker-health-check.sh
##########
@@ -15,6 +15,5 @@
# limitations under the License.
#
-sleep 5
+sleep 30
curl http://127.0.0.1:8848/nacos/v1/console/health/liveness
-sleep 10
Review comment:
make curl call to trigger nacos lazy initialization and sleep for waiting completely initialization. it's better to keep it unchaned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75697fe) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/e68ff8dd6c80536afbb4a8dfbc7ca3c1c6b6ab62?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e68ff8d) will **decrease** coverage by `0.22%`.
> The diff coverage is `58.82%`.
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 39.61% 39.39% -0.23%
===========================================
Files 54 54
Lines 3463 3460 -3
===========================================
- Hits 1372 1363 -9
- Misses 1929 1934 +5
- Partials 162 163 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `37.06% <36.36%> (-0.32%)` | :arrow_down: |
| [pkg/adapter/xds/cds.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIveGRzL2Nkcy5nbw==) | `57.02% <100.00%> (-0.36%)` | :arrow_down: |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e68ff8d...75697fe](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea19c6b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/4e636d69af69267c2bf1eeef59ad581cd0f26314?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e636d6) will **increase** coverage by `0.01%`.
> The diff coverage is `53.33%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
+ Coverage 39.27% 39.28% +0.01%
===========================================
Files 49 51 +2
Lines 3053 3098 +45
===========================================
+ Hits 1199 1217 +18
- Misses 1718 1743 +25
- Partials 136 138 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../loadbalancer/consistenthashing/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsdXN0ZXIvbG9hZGJhbGFuY2VyL2NvbnNpc3RlbnRoYXNoaW5nL2NvbnNpc3RlbnRfaGFzaC5nbw==) | `22.22% <22.22%> (ø)` | |
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `44.32% <36.36%> (-1.13%)` | :arrow_down: |
| [.../cluster/loadbalancer/consistenthashing/hashing.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsdXN0ZXIvbG9hZGJhbGFuY2VyL2NvbnNpc3RlbnRoYXNoaW5nL2hhc2hpbmcuZ28=) | `63.15% <63.15%> (ø)` | |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e636d6...ea19c6b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea19c6b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/4e636d69af69267c2bf1eeef59ad581cd0f26314?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e636d6) will **increase** coverage by `0.01%`.
> The diff coverage is `53.33%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
+ Coverage 39.27% 39.28% +0.01%
===========================================
Files 49 51 +2
Lines 3053 3098 +45
===========================================
+ Hits 1199 1217 +18
- Misses 1718 1743 +25
- Partials 136 138 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../loadbalancer/consistenthashing/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsdXN0ZXIvbG9hZGJhbGFuY2VyL2NvbnNpc3RlbnRoYXNoaW5nL2NvbnNpc3RlbnRfaGFzaC5nbw==) | `22.22% <22.22%> (ø)` | |
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `44.32% <36.36%> (-1.13%)` | :arrow_down: |
| [.../cluster/loadbalancer/consistenthashing/hashing.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsdXN0ZXIvbG9hZGJhbGFuY2VyL2NvbnNpc3RlbnRoYXNoaW5nL2hhc2hpbmcuZ28=) | `63.15% <63.15%> (ø)` | |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e636d6...ea19c6b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75697fe) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/e68ff8dd6c80536afbb4a8dfbc7ca3c1c6b6ab62?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e68ff8d) will **decrease** coverage by `0.22%`.
> The diff coverage is `58.82%`.
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 39.61% 39.39% -0.23%
===========================================
Files 54 54
Lines 3463 3460 -3
===========================================
- Hits 1372 1363 -9
- Misses 1929 1934 +5
- Partials 162 163 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `37.06% <36.36%> (-0.32%)` | :arrow_down: |
| [pkg/adapter/xds/cds.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIveGRzL2Nkcy5nbw==) | `57.02% <100.00%> (-0.36%)` | :arrow_down: |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e68ff8d...75697fe](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d8bd18) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/f786aa8ab6e263ebceb10f45c81c0b200b41adae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f786aa8) will **decrease** coverage by `0.22%`.
> The diff coverage is `58.82%`.
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 39.61% 39.39% -0.23%
===========================================
Files 54 54
Lines 3463 3460 -3
===========================================
- Hits 1372 1363 -9
- Misses 1929 1934 +5
- Partials 162 163 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `37.06% <36.36%> (-0.32%)` | :arrow_down: |
| [pkg/adapter/xds/cds.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIveGRzL2Nkcy5nbw==) | `57.02% <100.00%> (-0.36%)` | :arrow_down: |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f786aa8...6d8bd18](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1055081892
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (711387b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/4e636d69af69267c2bf1eeef59ad581cd0f26314?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e636d6) will **increase** coverage by `0.01%`.
> The diff coverage is `53.33%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
+ Coverage 39.27% 39.28% +0.01%
===========================================
Files 49 51 +2
Lines 3053 3098 +45
===========================================
+ Hits 1199 1217 +18
- Misses 1718 1743 +25
- Partials 136 138 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../loadbalancer/consistenthashing/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsdXN0ZXIvbG9hZGJhbGFuY2VyL2NvbnNpc3RlbnRoYXNoaW5nL2NvbnNpc3RlbnRfaGFzaC5nbw==) | `22.22% <22.22%> (ø)` | |
| [pkg/server/cluster\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9jbHVzdGVyX21hbmFnZXIuZ28=) | `44.32% <36.36%> (-1.13%)` | :arrow_down: |
| [.../cluster/loadbalancer/consistenthashing/hashing.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsdXN0ZXIvbG9hZGJhbGFuY2VyL2NvbnNpc3RlbnRoYXNoaW5nL2hhc2hpbmcuZ28=) | `63.15% <63.15%> (ø)` | |
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `64.63% <100.00%> (-4.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e636d6...711387b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/373?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur closed pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
ztelur closed pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] cityiron commented on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
cityiron commented on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1057630824
> use Rendezvous Hashing algorithm？
>
> https://en.wikipedia.org/wiki/Rendezvous_hashing
I think you can write it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] baerwang commented on pull request #373: feat:load balancer strategy mode and add consistent hash
Posted by GitBox <gi...@apache.org>.
baerwang commented on pull request #373:
URL: https://github.com/apache/dubbo-go-pixiu/pull/373#issuecomment-1057626070
use Rendezvous Hashing algorithm？
https://en.wikipedia.org/wiki/Rendezvous_hashing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org