[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #755: feat: support https and grpcs as upstream scheme as well as mTLS mode

[GitBox <gi...@apache.org>]

tao12345666333 commented on a change in pull request #755:
URL: https://github.com/apache/apisix-ingress-controller/pull/755#discussion_r754968830



##########
File path: test/e2e/testbackend/main.go
##########
@@ -0,0 +1,184 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more

Review comment:
       I think we can keep it like this for now

##########
File path: pkg/types/apisix/v1/types.go
##########
@@ -184,6 +188,13 @@ type Upstream struct {
 	Scheme  string               `json:"scheme,omitempty" yaml:"scheme,omitempty"`
 	Retries *int                 `json:"retries,omitempty" yaml:"retries,omitempty"`
 	Timeout *UpstreamTimeout     `json:"timeout,omitempty" yaml:"timeout,omitempty"`
+	TLS     *ClientTLS           `json:"tls,omitempty" yaml:"tls,omitempty"`
+}
+
+// ClientTLS is tls cert and key use in mTLS

Review comment:
       ```suggestion
   // ClientTLS contains tls cert and key used in mTLS
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org