You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/15 07:38:54 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39071: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
zhengruifeng opened a new pull request, #39071:
URL: https://github.com/apache/spark/pull/39071
### What changes were proposed in this pull request?
Implement the rest of string/binary functions. The first commit is https://github.com/apache/spark/pull/38921.
Among them, `format_number` has data type mismatch issue and should be enabled with https://issues.apache.org/jira/browse/SPARK-41473.
### Why are the changes needed?
For API coverage on Spark Connect.
### Does this PR introduce _any_ user-facing change?
Yes. New functions are available on Spark Connect.
### How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39071: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39071:
URL: https://github.com/apache/spark/pull/39071#issuecomment-1352705689
The failed dependency test is also irrelevant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39071: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39071: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
URL: https://github.com/apache/spark/pull/39071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39071: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39071:
URL: https://github.com/apache/spark/pull/39071#issuecomment-1352805270
cc @xinrong-meng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39071: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39071:
URL: https://github.com/apache/spark/pull/39071#issuecomment-1352806444
merged into master, thanks @HyukjinKwon for reivews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org