You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/06/09 11:57:56 UTC

[GitHub] [systemds] fathollahzadeh commented on pull request #1299: [SYSTEMDS-206] HDF5 File Format

fathollahzadeh commented on pull request #1299:
URL: https://github.com/apache/systemds/pull/1299#issuecomment-857632778


   > A few comments, I have issues with the syntax for @,,, , double array allocations, and the tests. but otherwise it looks fine.
   > I am unsure how much of the code is actually executed in the tests, maybe you want to see what parts are covered using jacoco?
   > 
   > most importantly the tests are missing verification of the actual values parsed and written to disk since the tests currently only verify that there are no crashes.
   
   Thanks for reviewing PR @Baunsgaard . I really appreciate your review and your comments.
   
   I fixed most of them and pushed them in separate commits. Also, some short responses to resolve the comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org