You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2016/01/13 18:50:38 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

GitHub user nitin-maharana opened a pull request:

    https://github.com/apache/cloudstack/pull/1338

    CLOUDSTACK-9236: Load Balancing Health Check button displayed when non-NetScaler offering is used

    Load balancing health check option / button should only be displayed when a NetScaler based networking offering is being used. 
    
    If you try to use the health check option when NetScaler is not being used as the load balancing technology the UI throws an error stating that the health check option is not supported. 
    
    This button / option should be removed from the UI if NetScaler is not included in the network offering as customers will be confused. 
    
    Fix:
    ===
    This button will be shown only when the load balancer is NetScaler.
    Otherwise it is hidden.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin21_4.7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1338
    
----
commit aec5e4e0de4fe449181f3c4ec67a636219d6e845
Author: Nitin Kumar Maharana <ni...@gmail.com>
Date:   2016-01-06T17:10:17Z

    CLOUDSTACK-9236: Load Balancing Health Check button displayed when non-NetScaler offering is used
    
    This button will be shown only when the load balancer is NetScaler.
    Otherwise it is hidden.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1338#issuecomment-171379436
  
    @nitin-maharana, if you create the function I suggested you to create in PR #1337, you could re-use it here. The code block 3637-3650 is the same as the one in the other PR and you are working in the same file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1338#issuecomment-172537670
  
    @nitin-maharana I like it when you put screenshots, as this speeds up my testing because I can see what you mean. I will test it soon, can you help me by putting a screenshot so that I look for the right thing? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1338#issuecomment-172966645
  
    I have some remarks about style (made one) but the logic looks fine. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1338#issuecomment-172545747
  
    LGTM based on these tests:
    
    Situation before when not using Netscaler:
    
    ![screen shot 2016-01-18 at 15 37 25](https://cloud.githubusercontent.com/assets/1630096/12394040/baae8bc6-bdf9-11e5-9443-23ff6f2c42cb.png)
    
    ![screen shot 2016-01-18 at 15 34 47](https://cloud.githubusercontent.com/assets/1630096/12394036/b5cc0b38-bdf9-11e5-9fc2-c29197c504ee.png)
    
    ![screen shot 2016-01-18 at 15 34 58](https://cloud.githubusercontent.com/assets/1630096/12394044/c048925c-bdf9-11e5-9188-b694f823332c.png)
    
    Basically, the button is displayed but throws an ugly message.
    
    After the fix in this PR the button is hidden:
    
    ![screen shot 2016-01-18 at 15 38 46](https://cloud.githubusercontent.com/assets/1630096/12394060/cffca7f6-bdf9-11e5-9c87-7cc739f5cc8e.png)
    
    Didn't test if it shows when using Netscaler, as I don't have it in my test environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:

    https://github.com/apache/cloudstack/pull/1338#issuecomment-171381086
  
    @rafaelweingartner : Super I will make the modification on both PRs. Thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:

    https://github.com/apache/cloudstack/pull/1338#issuecomment-173436054
  
    Thanks @remibergsma. Sorry I saw your comments bit late. You have already figured it out. Thanks @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1338


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---