You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 01:20:31 UTC

[PR] fix(i18n): localize topic list and toolbar [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3192:
URL: https://github.com/apache/rocketmq-dashboard/pull/3192

   ## Summary
   
   The topic page is being localized in slices; this PR covers the list surface: toolbar, current-instance banner, filters, table, row actions and batch operations.
   
   Localized in instance/topic.tsx:
   - Instance banner: 当前实例 / 接入模式 / 厂商 (阿里云 / 腾讯云) / 接入点 labels and the access-mode display and long-form description now resolve through keys; the access-label/description maps carry keys (`topic.cloudService`, `topic.accessDesc*`) with a small `instanceAccessLabel` helper.
   - List header subtitle (reusing `topic.totalCount`) and type-filter options (reusing `topic.normal/fifo/delay/transaction/lite` + `common.all`) via a label-key map.
   - Table headers and row buttons: Topic 名称 / 备注 / 类型 / 状态 (服务中) / 创建时间 / 修改时间 / 操作 with 详情 / 发送 / 删除 actions (all reusing existing `topic.*` keys).
   - Delete confirmation (title reusing `topic.confirmDelete`, content `topic.deleteContent` with the topic name, delete/cancel) and its success/error toasts (`topic.deleted`, new `topic.deleteFailed`).
   - Toolbar buttons 导入 / 导出 (reusing `common.import` / `common.export`), 同步数据 and 创建 Topic, plus export toasts (`topic.exportDone` / `topic.exportFailed`), the batch-delete dialog (`topic.confirmBatchDelete` + new content key), its result toasts (`topic.batchDeleted` reused, new partial/failed keys) and the pagination total (reusing `topic.showTotal`).
   - 19 new `topic.*` keys; zh byte-identical.
   
   ## Why
   
   The topic list is the main browsing surface; search, filters, status and destructive confirmations must read in the active language.
   
   ## Testing
   
   - `tsc --noEmit` passes
   - `eslint` clean on the changed files
   - `vitest run TopicPage` - 21/21 tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(i18n): localize topic list and toolbar [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3192: fix(i18n): localize topic list and toolbar
URL: https://github.com/apache/rocketmq-dashboard/pull/3192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org