You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/01 18:21:12 UTC

[GitHub] [calcite] amaliujia commented on a change in pull request #1991: [CALCITE-3916] Support top-down rule apply and upper bound space pruning

amaliujia commented on a change in pull request #1991:
URL: https://github.com/apache/calcite/pull/1991#discussion_r433407687



##########
File path: core/src/main/java/org/apache/calcite/config/CalciteConnectionProperty.java
##########
@@ -105,6 +105,10 @@
    * {@link org.apache.calcite.sql.parser.SqlParserImplFactory}. */
   PARSER_FACTORY("parserFactory", Type.PLUGIN, null, false),
 
+  /** Specifies whether to use top down optimization.
+   * {@link org.apache.calcite.plan.volcano.VolcanoPlanner#setTopDownOpt(boolean)} */
+  TOP_DOWN_OPT("topDownOpt", Type.BOOLEAN, true, false),

Review comment:
       Yes, Like what Haisheng said, enable top-down opt will generate different plans for existing tests. As we still under fast development for top-down opt, we thought it could be good to disable it globally for now. We will tackle those affected tests before fully enable top-down opt.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org