[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

["Fredy Wijaya (Code Review)" <ge...@cloudera.org>]

Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10541 )

Change subject: IMPALA-2751: Matching quotes are not required in comments
......................................................................

IMPALA-2751: Matching quotes are not required in comments

This patch fixes the issue where non-matching quotes inside comments
will cause the shell to not terminate.

The fix is to strip any SQL comments before sending to shlex since shlex
does not understand SQL comments and will raise an exception when it
sees
unmatched quotes regardless whether the quotes are in the comments or
not.

Testing:
- Added new shell tests
- Ran all end-to-end shell tests on Python 2.6 and Python 2.7

Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 26 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/10541/3
-- 
To view, visit http://gerrit.cloudera.org:8080/10541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c
Gerrit-Change-Number: 10541
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>